-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱E2e live iso ssh implementation #1453
🌱E2e live iso ssh implementation #1453
Conversation
/metal3-bmo-e2e-test |
762c5e7
to
afe00df
Compare
/metal3-bmo-e2e-test |
/test-ubuntu-integration-main |
94c79bd
to
755098b
Compare
755098b
to
372588f
Compare
18d3738
to
1b1f9c4
Compare
/test gomod |
47765a8
to
c312356
Compare
c312356
to
2fe5805
Compare
/metal3-bmo-e2e-test |
How I check if the node it booting from When booting from a Live-ISO (loaded into memory), the output is as follows:
In this case, you will not see a root filesystem (/) associated with a disk like /dev/vda1. Instead, the primary filesystems are memory-based (tmpfs). When booting from a normal ISO (booting from disk), the output includes a disk-based root filesystem:
Here, By examining the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great progress!
The ssh check will be useful also in other tests!
16153cb
to
b1f6f2f
Compare
0868797
to
f811712
Compare
/metal3-bmo-e2e-test |
1 similar comment
/metal3-bmo-e2e-test |
/test-centos-e2e-integration-main |
bccfa1e
to
a1335c0
Compare
implementation Signed-off-by: Max Rantil <[email protected]>
a1335c0
to
111df80
Compare
/metal3-bmo-e2e-test |
/test-centos-e2e-integration-main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
User: "cirros", | ||
Auth: []ssh.AuthMethod{ | ||
ssh.Password("gocubsgo"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note for the future: We should make this configurable and also support ssh keys. However, I think it is good enough for now since the ssh check can be disabled if needed.
I think we should work on this in a separate PR where we also add the ssh check to the other provisioning test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, I can do an issue on it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kashifest The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #1429