🌱 improve hack/verify-release.sh draft release note handling #1459
Conversation
Github API does not allow fetching draft release notes by tag, only by release id. Add the required code to fetch that, and also do not bail out if it fails, just skip the tests that require the data. Also fix osv-scanner exiting the script before printing the vulnerabilities. It returns failure when vulns are found. Signed-off-by: Tuomo Tanskanen <[email protected]>
metal3-io-bot
added
the
size/S
|
/override test-centos-e2e-integration-main |
|
@tuminoid: Overrode contexts on behalf of tuminoid: test-centos-e2e-integration-main, test-ubuntu-integration-main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kashifest The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
|
/cherry-pick release-0.4 |
|
@tuminoid: new pull request created: #1460 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-0.3 |
|
@tuminoid: new pull request created: #1461 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Github API does not allow fetching draft release notes by tag, only by release id. Add the required code to fetch that, and also do not bail out if it fails, just skip the tests that require the data.
Also fix osv-scanner exiting the script before printing the vulnerabilities. It returns failure when vulns are found.
Same has been implemented in CAPM3 and IPAM. This needs to be cherry-picked to release-0.4 and release-0.3 branches.