Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 e2e: Enhanced Serial Log Checking Functionality #1470

Merged
merged 1 commit into from
Dec 11, 2023
Merged

🌱 e2e: Enhanced Serial Log Checking Functionality #1470

merged 1 commit into from
Dec 11, 2023

Conversation

maxrantil
Copy link

Fixes #1466

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 30, 2023
@maxrantil maxrantil changed the title 🌱 e2e: Enhanced Serial Log Checking Functionality WIP: 🌱 e2e: Enhanced Serial Log Checking Functionality Nov 30, 2023
@metal3-io-bot metal3-io-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 30, 2023
@maxrantil
Copy link
Author

/metal3-bmo-e2e-test

@maxrantil maxrantil changed the title WIP: 🌱 e2e: Enhanced Serial Log Checking Functionality e2e: Enhanced Serial Log Checking Functionality Nov 30, 2023
@metal3-io-bot metal3-io-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 30, 2023
@maxrantil maxrantil changed the title e2e: Enhanced Serial Log Checking Functionality 🌱 e2e: Enhanced Serial Log Checking Functionality Nov 30, 2023
@maxrantil
Copy link
Author

/metal3-bmo-e2e-test

@maxrantil
Copy link
Author

/test-centos-e2e-integration-main
/test-ubuntu-integration-main

kashifest
kashifest reviewed Dec 1, 2023
View reviewed changes
Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 1, 2023
smoshiur1237
smoshiur1237 reviewed Dec 1, 2023
View reviewed changes
Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxrantil
Copy link
Author

/test-centos-e2e-integration-main

@maxrantil
Copy link
Author

What do you think @lentzi90 ?
/hold

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 1, 2023
lentzi90
lentzi90 reviewed Dec 4, 2023
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, but there is something wrong with it because I see no logs in the artifacts. Could you please check that?

hack/ci-e2e.sh Outdated Show resolved Hide resolved
@metal3-io-bot metal3-io-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 7, 2023
@maxrantil
Copy link
Author

maxrantil commented Dec 7, 2023 •
edited
Loading

The serial logs disappeared after they were written, so I needed to copy them over to the artifacts folder to save them. How do you like the solution now, @lentzi90 ?
There seems to be a security risk with this and I don't know how to get around it atm without using the flag to ignore it.

@maxrantil maxrantil force-pushed the e2e-serial-log-checking/max branch 3 times, most recently from d57807c to 0be7680 Compare December 8, 2023 05:53
@maxrantil
Copy link
Author

/metal3-bmo-e2e-test

@maxrantil
Copy link
Author

/test-centos-e2e-integration-main
/test-ubuntu-integration-main

lentzi90
lentzi90 reviewed Dec 8, 2023
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At what point do they disappear? Can we copy the logs after the test but before the make clean-e2e? I would like to keep this outside the go code if possible.

The security issue is no big deal. It is just that we do not know what file we read since it comes from a variable. In test code this is no issue.

@maxrantil
Copy link
Author

The logs disappear when the namespace is being deleted. That happens just after the LIVE-ISO test so I can't see a way of doing it outside the Go code if we don't change the cleanup code then.

@lentzi90
Copy link
Member

lentzi90 commented Dec 8, 2023

Can you check how this works in CAPM3? I don't think we touch the serial logs until after all the tests are done there.

@maxrantil maxrantil force-pushed the e2e-serial-log-checking/max branch 4 times, most recently from bee2859 to 89ca0df Compare December 8, 2023 13:00
@maxrantil
Copy link
Author

/metal3-bmo-e2e-test

@maxrantil
Copy link
Author

@lentzi90 Is this what you had in mind? The serial logs are now appended after each other in the file, is this the way?

@maxrantil maxrantil force-pushed the e2e-serial-log-checking/max branch 3 times, most recently from e845951 to 014b210 Compare December 8, 2023 18:19
@maxrantil
Copy link
Author

/metal3-bmo-e2e-test

@maxrantil
Copy link
Author

/metal3-bmo-e2e-test

lentzi90
lentzi90 reviewed Dec 11, 2023
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!
/lgtm
/cc @kashifest

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2023
@tuminoid
Copy link
Member

Looks clean, nice.

/test-centos-e2e-integration-main
/test-ubuntu-integration-main

@maxrantil
Copy link
Author

/remove hold

@maxrantil
Copy link
Author

/unhold

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 11, 2023
@metal3-io-bot metal3-io-bot merged commit b98fe2f into metal3-io:main Dec 11, 2023
15 checks passed
@metal3-io-bot metal3-io-bot deleted the e2e-serial-log-checking/max branch December 11, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoshiur1237 smoshiur1237 smoshiur1237 left review comments

@lentzi90 lentzi90 lentzi90 left review comments

@kashifest kashifest Awaiting requested review from kashifest

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

e2e: Enhanced Serial Log Checking Functionality
6 participants
@maxrantil @metal3-io-bot @lentzi90 @tuminoid @kashifest @smoshiur1237