Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 sync cert-manager version with preloaded images in e2e #1479

Merged
merged 1 commit into from
Dec 5, 2023
Merged

🌱 sync cert-manager version with preloaded images in e2e #1479

merged 1 commit into from
Dec 5, 2023

Conversation

tuminoid
Copy link
Member

@tuminoid tuminoid commented Dec 5, 2023

This allows e2e test to use preloaded images and not waste time to do double download.

@tuminoid
sync cert-manager version with preloaded images
e46c82c 
This allows e2e test to use preloaded images and not waste time to
do double download.

Signed-off-by: Tuomo Tanskanen <[email protected]>
@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 5, 2023
@tuminoid
Copy link
Member Author

tuminoid commented Dec 5, 2023

/cc @lentzi90 @kashifest

lentzi90
lentzi90 reviewed Dec 5, 2023
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2023
@lentzi90
Copy link
Member

lentzi90 commented Dec 5, 2023

/metal3-bmo-e2e-test

@kashifest
Copy link
Member

/approve
/override test-centos-e2e-integration-main
/override test-ubuntu-integration-main

@metal3-io-bot
Copy link
Contributor

@kashifest: Overrode contexts on behalf of kashifest: test-centos-e2e-integration-main, test-ubuntu-integration-main

In response to this:

/approve
/override test-centos-e2e-integration-main
/override test-ubuntu-integration-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2023
@metal3-io-bot metal3-io-bot merged commit 9820a12 into metal3-io:main Dec 5, 2023
15 checks passed
@metal3-io-bot metal3-io-bot deleted the tuomo/fix-cert-manager-in-e2e branch December 5, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lentzi90 lentzi90 lentzi90 left review comments

@kashifest kashifest Awaiting requested review from kashifest

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tuminoid @lentzi90 @kashifest @metal3-io-bot