-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add an explicit way to auto-detect ChecksumType #1480
Conversation
/cc @hardys |
/test-centos-e2e-integration-main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@Rozzii: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
6dd20e3
to
7893564
Compare
/test-centos-e2e-integration-main This was just a rebase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
I think I disagree with this change. This is not about removing MD5, since it's still possible to specify MD5 explicitly. The is about changing the type field from required to optional for SHA sums. That means that the same v1alpha1 CR may fail to work on older versions of Metal³ - or, as you acknowledge in the description, on the same version of Metal³ with different versions of IPA. Essentially this is starting to leak Ironic API changes through into the BMH. If we want to remove the type field in v1beta1 (which I'm fine with) we can still translate back to v1alpha1 when required in the webhook by using the same logic that Ironic does (checking the length of the sum) to determine the algorithm. As far as I can see, this change is not required to do that. |
We cannot, this logic is not trivial, and I don't want to replicate it there (it's not just length, there are many formats of downloadable checksums). @zaneb would you be more okay with an explicit |
7893564
to
6ba48dd
Compare
Okay, this should no longer break the backward compatibility with older IPA. |
/test-centos-e2e-integration-main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy with this 👍
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Rozzii, zaneb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In preparation for the eventual removal of MD5 checksums, add a new ChecksumType "auto" that instructs IPA to detect the type Requires IPA from the 2023.2 release series. Users with older IPA should provide the algorithm explicitly. Signed-off-by: Dmitry Tantsur <[email protected]>
6ba48dd
to
0ed5eb1
Compare
/test-centos-e2e-integration-main |
/test-ubuntu-integration-main |
Thanks for the heads-up 👍 /lgtm |
@hardys: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/test-ubuntu-integration-main |
In preparation for the eventual removal of MD5 checksums, add a new
ChecksumType "auto" that instructs IPA to detect the type
Requires IPA from the 2023.2 release series. Users with older IPA
should provide the algorithm explicitly.
Signed-off-by: Dmitry Tantsur [email protected]