-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix htpasswd command not found #1486
Conversation
/test-centos-e2e-integration-main |
/metal3-bmo-e2e-test |
if ! [ -x "$(command -v htpasswd)" ]; then | ||
echo "htpasswd could not be found, installing..." | ||
sudo apt-get update | ||
sudo apt-get install -y apache2-utils |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not specific to this PR, but generally these hack/e2e/
scripts wont work locally for a mac user like me. I will add an issue to make it work for other architectures as well.
cc @lentzi90 @maxrantil
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it would be great to make this more flexible so it can work also for development and not just CI. So far my focus has been to just set up the CI, but for the long term I definitely intend to make this easier for developers to use locally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dis-asgree here. My understanding was the hack/
scripts are also used to test the CI test locally. If hack/e2e
scripts are not meant to be used by developers locally, then I can agree.
I would ask that you do not make the CI unnecessarily complicated just to accommodate mac users though 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyways, I have created an issue here anyhow #1487, lets discuss it on the issue.
/approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kashifest The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit.
/hold |
b814bb7
to
05aad53
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold cancel |
Signed-off-by: peppi-lotta <[email protected]>
05aad53
to
dfc7579
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/test-centos-e2e-integration-main |
/override test-ubuntu-integration-main |
@tuminoid: Overrode contexts on behalf of tuminoid: test-ubuntu-integration-main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
Fixes #1485