Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 E2e: Change the filename of basic_provisioning_test.go to provisioning_and_annotation_test.go. #1493

Merged
merged 1 commit into from
Jan 8, 2024
Merged

🌱 E2e: Change the filename of basic_provisioning_test.go to provisioning_and_annotation_test.go. #1493

merged 1 commit into from
Jan 8, 2024

Conversation

maxrantil
Copy link
Member

What this PR does / why we need it:
Change the filename to something more descriptive to accurately represent all the tests being conducted.

@metal3-io-bot metal3-io-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 15, 2023
@maxrantil maxrantil changed the title 🌱 Change the filename of basic_provisioning_test.go to provisioning_and_annotation_test.go. 🌱 E2e: Change the filename of basic_provisioning_test.go to provisioning_and_annotation_test.go. Dec 15, 2023
@maxrantil maxrantil force-pushed the basic-provisioning-test-name-change/max branch from ef22016 to 1fcb210 Compare December 15, 2023 12:35
@metal3-io-bot metal3-io-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 15, 2023
smoshiur1237
smoshiur1237 reviewed Dec 15, 2023
View reviewed changes
Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lentzi90
lentzi90 reviewed Dec 15, 2023
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2023
@maxrantil
Copy link
Member Author

/test-centos-e2e-integration-main
/test-ubuntu-integration-main
/metal3-bmo-e2e-test

@maxrantil
Copy link
Member Author

/test-ubuntu-integration-main

1 similar comment
@maxrantil
Copy link
Member Author

/test-ubuntu-integration-main

@metal3-io-bot metal3-io-bot added the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Dec 18, 2023
@maxrantil maxrantil force-pushed the basic-provisioning-test-name-change/max branch from 1fcb210 to cd1b89e Compare December 19, 2023 10:48
@metal3-io-bot metal3-io-bot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 19, 2023
lentzi90
lentzi90 reviewed Dec 19, 2023
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2023
@maxrantil
Copy link
Member Author

maxrantil commented Dec 19, 2023 •
edited
Loading

/cc @kashifest

After review if you think it is fine, maybe you could bypass the tests for this PR?

@maxrantil maxrantil force-pushed the basic-provisioning-test-name-change/max branch from cd1b89e to 8e21927 Compare December 19, 2023 14:50
@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2023
lentzi90
lentzi90 reviewed Dec 20, 2023
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 20, 2023
kashifest
kashifest reviewed Jan 8, 2024
View reviewed changes
Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2024
@kashifest
Copy link
Member

/override test-centos-e2e-integration-main
/override test-ubuntu-integration-main

@metal3-io-bot
Copy link
Contributor

@kashifest: Overrode contexts on behalf of kashifest: test-centos-e2e-integration-main, test-ubuntu-integration-main

In response to this:

/override test-centos-e2e-integration-main
/override test-ubuntu-integration-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot metal3-io-bot merged commit a416d66 into metal3-io:main Jan 8, 2024
14 checks passed
@metal3-io-bot metal3-io-bot deleted the basic-provisioning-test-name-change/max branch January 8, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lentzi90 lentzi90 lentzi90 left review comments

@kashifest kashifest kashifest left review comments

@smoshiur1237 smoshiur1237 smoshiur1237 left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@maxrantil @metal3-io-bot @kashifest @lentzi90 @smoshiur1237