-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Bump controller-runtime, k8s/*, CAPM3/test and other related go modules #1515
Conversation
/hold |
878251b
to
968b964
Compare
/metal3-bmo-e2e-test |
/hold cancel |
Can you mention in the description why the metrics is removed? |
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Signed-off-by: Kashif Khan <[email protected]>
968b964
to
9425ff4
Compare
/metal3-bmo-e2e-test |
Thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zaneb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Bump
MetricsBindAddress is deprecated. We now use metricsServer options to accomodate the bindAddress