Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Bump golang to v1.21.6 #1535

Merged
merged 1 commit into from
Feb 9, 2024
Merged

🌱 Bump golang to v1.21.6 #1535

merged 1 commit into from
Feb 9, 2024

Conversation

kashifest
Copy link
Member

as the title says

@kashifest
Bump golang to v1.21.6
628cae7 
Signed-off-by: Kashif Khan <[email protected]>
@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 30, 2024
@kashifest
Copy link
Member Author

/hold
this requires project-infra patch to pass the prow test

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 30, 2024
@kashifest
Copy link
Member Author

/test metal3-bmo-e2e-test-pull
/test-centos-e2e-integration-main
/test-ubuntu-integration-main

@kashifest
Copy link
Member Author

go.mod prow test would require this metal3-io/project-infra#627

@kashifest
Copy link
Member Author

/cc @zaneb @honza @dtantsur @elfosardo

@kashifest
Copy link
Member Author

kashifest commented Feb 6, 2024 •
edited
Loading

/cc @zaneb @honza @dtantsur

@dtantsur
Copy link
Member

dtantsur commented Feb 7, 2024

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2024
tuminoid
tuminoid reviewed Feb 9, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 9, 2024
@tuminoid
Copy link
Member

tuminoid commented Feb 9, 2024

Needs metal3-io/project-infra#627 to go in first.

@kashifest
Copy link
Member Author

/retest

1 similar comment
@kashifest
Copy link
Member Author

/retest

@kashifest
Copy link
Member Author

/test all

@kashifest
Copy link
Member Author

/hold cancel

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 9, 2024
@metal3-io-bot metal3-io-bot merged commit 3dcb120 into metal3-io:main Feb 9, 2024
21 checks passed
@metal3-io-bot metal3-io-bot deleted the bump/golang-v1.21 branch February 9, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuminoid tuminoid tuminoid left review comments

@dtantsur dtantsur Awaiting requested review from dtantsur

@elfosardo elfosardo Awaiting requested review from elfosardo

@honza honza Awaiting requested review from honza

@zaneb zaneb Awaiting requested review from zaneb

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kashifest @dtantsur @metal3-io-bot @tuminoid