Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 E2E: Increase some intervals #1546

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

lentzi90
Copy link
Member

@lentzi90 lentzi90 commented Feb 5, 2024

What this PR does / why we need it:

Some of the tests have been a bit flaky. It seems that ipmi/vbmc is slightly slower than redfish/sushy-tools and this is causing timeouts in some tests. This commit increases two waiting intervals that were a bit on the short side.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Some of the tests have been a bit flaky. It seems that ipmi/vbmc is
slightly slower than redfish/sushy-tools and this is causing timeouts in
some tests. This commit increases two waiting intervals that were
a bit on the short side.

Signed-off-by: Lennart Jern <[email protected]>
@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 5, 2024
@lentzi90
Copy link
Member Author

lentzi90 commented Feb 5, 2024

/test metal3-bmo-e2e-test-pull

@lentzi90
Copy link
Member Author

lentzi90 commented Feb 5, 2024

/test-centos-e2e-integration-main

Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 5, 2024
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2024
@metal3-io-bot metal3-io-bot merged commit 4b2a69d into metal3-io:main Feb 5, 2024
19 checks passed
@metal3-io-bot metal3-io-bot deleted the lentzi90/e2e-intervals branch February 5, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants