Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Add alternative Tilt setup method to documentation #1558

Merged
merged 1 commit into from
Feb 28, 2024
Merged

📖 Add alternative Tilt setup method to documentation #1558

merged 1 commit into from
Feb 28, 2024

Conversation

maxrantil
Copy link

What this PR does / why we need it:
This PR updates the project's documentation to include an alternative method for setting up the development environment using Tilt and Kind.

@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 15, 2024
@maxrantil maxrantil force-pushed the alternative-tilt-setup-guide/max branch 4 times, most recently from 42752af to d76a3de Compare February 15, 2024 07:15
lentzi90
lentzi90 reviewed Feb 15, 2024
View reviewed changes
docs/dev-setup.md Outdated Show resolved Hide resolved
docs/dev-setup.md Outdated Show resolved Hide resolved
docs/dev-setup.md Outdated Show resolved Hide resolved
@maxrantil maxrantil force-pushed the alternative-tilt-setup-guide/max branch 2 times, most recently from 3dbc00b to c215066 Compare February 16, 2024 07:58
@metal3-io-bot metal3-io-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 16, 2024
@lentzi90
Add alternative Tilt setup method to documentation
8a1b193 
Signed-off-by: Max Rantil <[email protected]>
Co-authored-by: Lennart Jern <[email protected]>
@maxrantil maxrantil force-pushed the alternative-tilt-setup-guide/max branch from c215066 to 8a1b193 Compare February 16, 2024 08:07
lentzi90
lentzi90 reviewed Feb 16, 2024
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 16, 2024
@dtantsur
Copy link
Member

/approve
/override metal3-bmo-e2e-test-pull
/override test-centos-e2e-integration-main

@metal3-io-bot
Copy link
Contributor

@dtantsur: Overrode contexts on behalf of dtantsur: metal3-bmo-e2e-test-pull, test-centos-e2e-integration-main

In response to this:

/approve
/override metal3-bmo-e2e-test-pull
/override test-centos-e2e-integration-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2024
@metal3-io-bot metal3-io-bot merged commit dc11e18 into metal3-io:main Feb 28, 2024
13 checks passed
@metal3-io-bot metal3-io-bot deleted the alternative-tilt-setup-guide/max branch February 28, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lentzi90 lentzi90 lentzi90 left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maxrantil @dtantsur @metal3-io-bot @lentzi90