⚠️ Update to gophercloud 2.0.0-beta2 #1569
Conversation
Although the current version is specified as 1.5.1, it's actually a commit somewhere in the 2.0 branch. This change brings us to a more specific version. 2.0.0-beta2 introduced a requirement on Context for all calls. Signed-off-by: Dmitry Tantsur <[email protected]>
metal3-io-bot
added
the
size/L
|
/test metal3-bmo-e2e-test-pull |
Signed-off-by: Dmitry Tantsur <[email protected]>
|
/test metal3-bmo-e2e-test-pull |
3 similar comments
|
/test metal3-bmo-e2e-test-pull |
|
/test metal3-bmo-e2e-test-pull |
|
/test metal3-bmo-e2e-test-pull |
| @@ -1,11 +1,11 @@ | |||
| module github.com/metal3-io/baremetal-operator | |||
|
|
|||
| go 1.21 | |||
| go 1.21.6 | |||
There was a problem hiding this comment.
Any specific reason to pin it to patch version?
There was a problem hiding this comment.
This is apparently the new way Go does it starting with 1.21. I haven't done this change - go mod tidy does it (based on Gophercloud's go.mod, I believe).
There was a problem hiding this comment.
Interesting , I didnt face it when I bumped it to go 1.21, I have to check it again.
There was a problem hiding this comment.
This is probably because it is pinned in Gophercloud v2 as well, https://github.com/gophercloud/gophercloud/blob/master/go.mod#L3, When I do go mod tidy in CAPM3 main, it doesn't require a patch version. Even if you do go mod tidy in the apis dir, this wont be needed. Now I am thinking would this be always like this that we have to keep this patch version in sync with Gophercloud which is not desirable IMO, but what else can we do ? May be as long as this version is >= gophercloud version, it would work.
There was a problem hiding this comment.
This is how I read the discussion at golang/go#63370, yes. But we might be forced to go to 1.22.0 rather than 1.22 in the future. We'll see.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kashifest The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
|
/test-centos-e2e-integration-main |
|
/lgtm |
Although the current version is specified as 1.5.1, it's actually
a commit somewhere in the 2.0 branch. This change brings us to
a more specific version.
2.0.0-beta2 introduced a requirement on Context for all calls.
Signed-off-by: Dmitry Tantsur [email protected]