Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 add golang base image check to verify-release.sh for release-0.5 #1617

Merged
merged 1 commit into from
Mar 12, 2024
Merged

🌱 add golang base image check to verify-release.sh for release-0.5 #1617

merged 1 commit into from
Mar 12, 2024

Conversation

metal3-io-bot
Copy link
Contributor

This is an automated cherry-pick of #1614

/assign tuminoid

@tuminoid
add golang base image check to verify-release.sh
7b44954 
Make verify-release.sh check also if the golang base image is most
recent of the minor series.

Signed-off-by: Tuomo Tanskanen <[email protected]>
@metal3-io-bot metal3-io-bot mentioned this pull request Mar 12, 2024
Merged
@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 12, 2024
@tuminoid
Copy link
Member

/override test-ubuntu-integration-release-1-6 test-centos-e2e-integration-release-1-6 metal3-bmo-e2e-test-pull

@metal3-io-bot
Copy link
Contributor Author

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-bmo-e2e-test-pull, test-centos-e2e-integration-release-1-6, test-ubuntu-integration-release-1-6

In response to this:

/override test-ubuntu-integration-release-1-6 test-centos-e2e-integration-release-1-6 metal3-bmo-e2e-test-pull

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tuminoid
tuminoid reviewed Mar 12, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 12, 2024
@tuminoid
Copy link
Member

/retitle 🌱 add golang base image check to verify-release.sh for release-0.5

@metal3-io-bot metal3-io-bot changed the title [release-0.5] 🌱 add golang base image check to verify-release.sh 🌱 add golang base image check to verify-release.sh for release-0.5 Mar 12, 2024
@tuminoid
Copy link
Member

/assign @kashifest

@kashifest
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 12, 2024
@metal3-io-bot metal3-io-bot merged commit 253f408 into metal3-io:release-0.5 Mar 12, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuminoid tuminoid tuminoid left review comments

Assignees

@tuminoid tuminoid

@kashifest kashifest

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@metal3-io-bot @tuminoid @kashifest