-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 add workflow to approve actions on PR change #1654
🌱 add workflow to approve actions on PR change #1654
Conversation
If external contributor adds a PR, and a member /ok-to-test it, GH actions do not run until approved by an approver. This approval needs to be given if the PR content changes, so it inconveniences the contributor but also the approver. This PR approves workflows, if ok-to-test label is present. Adapted from CAPI workflow: https://github.com/kubernetes-sigs/cluster-api/blob/main/.github/workflows/pr-gh-workflow-approve.yaml Signed-off-by: Tuomo Tanskanen <[email protected]>
IPAM tested: metal3-io/ip-address-manager#485 (comment) /unhold |
IPAM test already shows this works. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kashifest The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override test-centos-e2e-integration-main metal3-bmo-e2e-test-pull |
@kashifest: Overrode contexts on behalf of kashifest: metal3-bmo-e2e-test-pull, test-centos-e2e-integration-main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
If external contributor adds a PR, and a member /ok-to-test it, GH actions do not run until approved by an approver. This approval needs to be given if the PR content changes, so it inconveniences the contributor but also the approver.
This PR approves workflows, if ok-to-test label is present.
Adapted from CAPI workflow:
https://github.com/kubernetes-sigs/cluster-api/blob/main/.github/workflows/pr-gh-workflow-approve.yaml
Same as metal3-io/ip-address-manager#485
/hold
until IPAM workflow gets tested.