Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 add workflow to approve actions on PR change #1654

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

tuminoid
Copy link
Member

@tuminoid tuminoid commented Apr 5, 2024

If external contributor adds a PR, and a member /ok-to-test it, GH actions do not run until approved by an approver. This approval needs to be given if the PR content changes, so it inconveniences the contributor but also the approver.

This PR approves workflows, if ok-to-test label is present.

Adapted from CAPI workflow:
https://github.com/kubernetes-sigs/cluster-api/blob/main/.github/workflows/pr-gh-workflow-approve.yaml

Same as metal3-io/ip-address-manager#485

/hold
until IPAM workflow gets tested.

If external contributor adds a PR, and a member /ok-to-test it, GH
actions do not run until approved by an approver. This approval needs
to be given if the PR content changes, so it inconveniences the
contributor but also the approver.

This PR approves workflows, if ok-to-test label is present.

Adapted from CAPI workflow:
https://github.com/kubernetes-sigs/cluster-api/blob/main/.github/workflows/pr-gh-workflow-approve.yaml

Signed-off-by: Tuomo Tanskanen <[email protected]>
@metal3-io-bot metal3-io-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 5, 2024
@tuminoid
Copy link
Member Author

tuminoid commented Apr 8, 2024

IPAM tested: metal3-io/ip-address-manager#485 (comment)

/unhold

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 8, 2024
@kashifest
Copy link
Member

IPAM test already shows this works.
/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2024
@kashifest
Copy link
Member

/override test-centos-e2e-integration-main metal3-bmo-e2e-test-pull
e2e tests wont test the workflow

@metal3-io-bot
Copy link
Contributor

@kashifest: Overrode contexts on behalf of kashifest: metal3-bmo-e2e-test-pull, test-centos-e2e-integration-main

In response to this:

/override test-centos-e2e-integration-main metal3-bmo-e2e-test-pull
e2e tests wont test the workflow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2024
@metal3-io-bot metal3-io-bot merged commit fb91b5b into metal3-io:main Apr 8, 2024
16 checks passed
@metal3-io-bot metal3-io-bot deleted the tuomo/add-gh-action-approver branch April 8, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants