Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 improve hack/verify-release.sh script #1691

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

tuminoid
Copy link
Member

@tuminoid tuminoid commented Apr 23, 2024

Few improvements from previous minor release cycle:

  • add missing k8s.io/apiserver to module sync
  • change artefact to artifact for more common spelling
  • match container image detection from release notes to match the earlier change in the release tooling
  • rename some of the titles to be more descriptive
  • mutate go.mod files for osv-scanner so it can accurately report vulnerablities in golang stdlib (ie. mutate "go 1.21" directive to "go 1.21.9" with patch version read off from main Dockerfile
  • add version check for some tools, otherwise they'll give confusing output

This will be cherry-picked to 0.6 and 0.5 after it merges here as it affects patch release checks.

@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 23, 2024
@tuminoid tuminoid force-pushed the tuomo/improve-verify-release branch 2 times, most recently from 53b4303 to 506c1b0 Compare April 23, 2024 08:31
Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test run locally and it is working as expected.
LGTM

@tuminoid tuminoid force-pushed the tuomo/improve-verify-release branch from 506c1b0 to 11d5745 Compare April 23, 2024 12:21
@metal3-io-bot metal3-io-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 23, 2024
Few improvements from previous minor release cycle:

- add missing k8s.io/apiserver to module sync
- change artefact to artifact for more common spelling
- match container image detection from release notes to match the
  earlier change in the release tooling
- rename some of the titles to be more descriptive
- mutate go.mod files for osv-scanner so it can accurately report
  vulnerablities in golang stdlib (ie. mutate "go 1.21" directive to
  "go 1.21.9" with patch version read off from main Dockerfile
- check version of osv-scanner, <1.5.0 give weird warnings now
- make docker pull gcrane and osv-scanner images always, so it uses
  the newest versions

Signed-off-by: Tuomo Tanskanen <[email protected]>
@tuminoid tuminoid force-pushed the tuomo/improve-verify-release branch from 11d5745 to fa112c8 Compare April 23, 2024 12:31
@tuminoid
Copy link
Member Author

Added version check for some tools, otherwise they'll give confusing output. osv-scanner minimum version is 1.5.0. PTAL again.

@tuminoid
Copy link
Member Author

/ok-to-test

@metal3-io-bot metal3-io-bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Apr 24, 2024
@tuminoid
Copy link
Member Author

/cc @elfosardo @lentzi90 @kashifest

Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2024
Copy link
Member

@adilGhaffarDev adilGhaffarDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot
Copy link
Contributor

@adilGhaffarDev: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adilGhaffarDev, lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kashifest
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2024
@tuminoid
Copy link
Member Author

/ok-to-test

@tuminoid
Copy link
Member Author

/override metal3-bmo-e2e-test-pull metal3-centos-e2e-integration-test-main

@metal3-io-bot
Copy link
Contributor

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-bmo-e2e-test-pull, metal3-centos-e2e-integration-test-main

In response to this:

/override metal3-bmo-e2e-test-pull metal3-centos-e2e-integration-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tuminoid
Copy link
Member Author

/retitle 🌱 improve hack/verify-release.sh script
for prow....

@metal3-io-bot metal3-io-bot changed the title 🌱 improve hack/verify-release.sh 🌱 improve hack/verify-release.sh script Apr 24, 2024
@metal3-io-bot metal3-io-bot merged commit ed39ffa into metal3-io:main Apr 24, 2024
35 of 36 checks passed
@metal3-io-bot metal3-io-bot deleted the tuomo/improve-verify-release branch April 24, 2024 13:09
@tuminoid
Copy link
Member Author

/cherry-pick release-0.6

0.5 needs manual cherrypick.

@metal3-io-bot
Copy link
Contributor

@tuminoid: new pull request created: #1697

In response to this:

/cherry-pick release-0.6

0.5 needs manual cherrypick.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tuminoid
Copy link
Member Author

0.5 needs manual cherrypick.

/cherry-pick release-0.5
Actually I backported the incompatible changes in release notes generator so this should be fine.

@metal3-io-bot
Copy link
Contributor

@tuminoid: new pull request created: #1698

In response to this:

0.5 needs manual cherrypick.

/cherry-pick release-0.5
Actually I backported the incompatible changes in release notes generator so this should be fine.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants