Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 enable gci linter and fix go imports #1704

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

kashifest
Copy link
Member

This PR adds gci linter and fixes according to gci suggestions. This is part of #1642

This PR adds gci linter and fixes according to gci suggestions. This is part of metal3-io#1642

Signed-off-by: Kashif Khan <[email protected]>
@metal3-io-bot metal3-io-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 29, 2024
@kashifest kashifest changed the title 🌱 Enable gci linted and fix go imports 🌱 Enable gci linter and fix go imports Apr 29, 2024
@kashifest
Copy link
Member Author

/test metal3-bmo-e2e-test-pull
/test metal3-centos-e2e-integration-test-main

Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 30, 2024
@kashifest
Copy link
Member Author

/cc @Rozzii

Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2024
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90, Rozzii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kashifest
Copy link
Member Author

/ok-to-test

@metal3-io-bot metal3-io-bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Apr 30, 2024
@kashifest kashifest changed the title 🌱 Enable gci linter and fix go imports 🌱 enable gci linter and fix go imports Apr 30, 2024
@metal3-io-bot metal3-io-bot merged commit 1a289a4 into metal3-io:main Apr 30, 2024
29 checks passed
@metal3-io-bot metal3-io-bot deleted the enable/gci branch April 30, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants