Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Add mquhuy as a reviewer #1726

Merged
merged 1 commit into from
May 13, 2024
Merged

🌱 Add mquhuy as a reviewer #1726

merged 1 commit into from
May 13, 2024

Conversation

mquhuy
Copy link
Member

@mquhuy mquhuy commented May 13, 2024

Adding myself as a reviewer for BMO

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 13, 2024
kashifest
kashifest reviewed May 13, 2024
View reviewed changes
Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Thanks @mquhuy for your contributions and stepping up as a reviewer.

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2024
@kashifest
Copy link
Member

/override metal3-bmo-e2e-test-pull
No need to test it. Its OWNERS file change only.

@metal3-io-bot
Copy link
Contributor

@kashifest: Overrode contexts on behalf of kashifest: metal3-bmo-e2e-test-pull

In response to this:

/override metal3-bmo-e2e-test-pull
No need to test it. Its OWNERS file change only.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kashifest
Copy link
Member

/cc @tuminoid @lentzi90

lentzi90
lentzi90 reviewed May 13, 2024
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2024
@metal3-io-bot metal3-io-bot merged commit 7037f02 into metal3-io:main May 13, 2024
11 checks passed
@metal3-io-bot metal3-io-bot deleted the add-reviewer-mquhuy branch May 13, 2024 08:41
@tuminoid
Copy link
Member

/cherry-pick release-0.6
This was missed

@tuminoid
Copy link
Member

/cherry-pick release-0.5

@metal3-io-bot metal3-io-bot mentioned this pull request May 20, 2024
Merged
@metal3-io-bot
Copy link
Contributor

@tuminoid: new pull request created: #1732

In response to this:

/cherry-pick release-0.6
This was missed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot
Copy link
Contributor

@tuminoid: new pull request created: #1733

In response to this:

/cherry-pick release-0.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot metal3-io-bot mentioned this pull request May 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kashifest kashifest kashifest left review comments

@lentzi90 lentzi90 lentzi90 left review comments

@elfosardo elfosardo Awaiting requested review from elfosardo

@tuminoid tuminoid Awaiting requested review from tuminoid

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mquhuy @metal3-io-bot @kashifest @tuminoid @lentzi90