Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix make install and make uninstall #1789

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

matthewei
Copy link

@matthewei matthewei commented Jun 17, 2024

🐛 fix make install and make uninstall

What this PR does / why we need it:
fix make install and make uninstall

Which issue(s) this PR fixes:
Fixes #1788

@metal3-io-bot metal3-io-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 17, 2024
@metal3-io-bot
Copy link
Contributor

Hi @matthewei. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 17, 2024
@tuminoid
Copy link
Member

/ok-to-test

Put the emoji to the start of the title line to fix PR verifier failures.

@metal3-io-bot metal3-io-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 17, 2024
@matthewei matthewei changed the title fix make install and make uninstall 🐛 fix make install and make uninstall Jun 17, 2024
@matthewei
Copy link
Author

/ok-to-test

Put the emoji to the start of the title line to fix PR verifier failures.

done

@matthewei
Copy link
Author

@dhellmann Do you have any comments?

@elfosardo
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2024
@dtantsur
Copy link
Member

/approve

Next time, please provide a more descriptive commit/PR message. "Fix something" is usually not enough: you need to at least specify what is broken (obvious here but won't be in even slightly more complex case).

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2024
@metal3-io-bot metal3-io-bot merged commit ef87e23 into metal3-io:main Jun 24, 2024
46 of 49 checks passed
@matthewei
Copy link
Author

/approve

Next time, please provide a more descriptive commit/PR message. "Fix something" is usually not enough: you need to at least specify what is broken (obvious here but won't be in even slightly more complex case).

got it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cant use "make install" and "make uninstall" to install or uninstll CRD
5 participants