-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 fix make install and make uninstall #1789
Conversation
Hi @matthewei. Thanks for your PR. I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: shenwei <[email protected]>
7d556a6
to
122daf0
Compare
/ok-to-test Put the emoji to the start of the title line to fix PR verifier failures. |
done |
@dhellmann Do you have any comments? |
/lgtm |
/approve Next time, please provide a more descriptive commit/PR message. "Fix something" is usually not enough: you need to at least specify what is broken (obvious here but won't be in even slightly more complex case). |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtantsur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
got it |
🐛 fix make install and make uninstall
What this PR does / why we need it:
fix make install and make uninstall
Which issue(s) this PR fixes:
Fixes #1788