🌱 E2E: Remove gomega in LoadBMCConfig() #1806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Huy Mai <[email protected]>
metal3-io-bot
added
the
size/S
mquhuy
force-pushed
the
mquhuy/remove-gomega-from-bmc.go
branch
from
79f06df
to
23246c9
Compare
metal3-io-bot
requested review from
adilGhaffarDev,
huutomerkki,
mboukhalfa,
Rozzii,
Sunnatillo and
tuminoid
|
@adilGhaffarDev: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
dtantsur
approved these changes
Jul 4, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtantsur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A minor PR to not use gomega's
Expect()inLoadBMCConfig().Reason: Using
Expect()inside the function prevents reusage of the function in locations where ginkgo is not in use (e.g. #1767). This inclusion is unnecessary anyway, andExpect()should be located in the e2e suite.