Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 schedule dependabot on certain day, and add ok-to-test automatically #1816

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

tuminoid
Copy link
Member

@tuminoid tuminoid commented Jul 4, 2024

BMO schedule:

  • GH actions: saturday
  • Gomod: sunday

Automatically add labels:

  • ok-to-test

We have dynamic Prow scheduling now and proper requests, we should not suffer from load failures in very basic tests anymore. BMO is scheduled for weekend as it automatically runs BMO e2e etc, which are bit more heavy than the Prow-only linters in CAPM3/IPAM. Also it means they are tested by Monday morning to easier merging.

Fix some formatting and move blocks around so they're consistent with release branches.

BMO schedule:
- GH actions: saturday
- Gomod: sunday

Automatically add labels:
- ok-to-test

We have dynamic Prow scheduling now and proper requests, we should not
suffer from load failures in very basic tests anymore.

BMO is scheduled for weekend as it automatically runs BMO e2e etc,
which are bit more heavy than the Prow-only linters in CAPM3/IPAM.
Also it means they are tested by Monday morning to easier merging.

Signed-off-by: Tuomo Tanskanen <[email protected]>
@tuminoid
Copy link
Member Author

tuminoid commented Jul 4, 2024

/cc @kashifest

@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 4, 2024
Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 4, 2024
Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 4, 2024
@metal3-io-bot metal3-io-bot merged commit 4fbcda2 into metal3-io:main Jul 4, 2024
16 of 17 checks passed
@metal3-io-bot metal3-io-bot deleted the tuomo/add-dependabot-schedule branch July 4, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants