Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Move container build to gh runner #1861

Merged
merged 1 commit into from
Aug 8, 2024
Merged

🌱 Move container build to gh runner #1861

merged 1 commit into from
Aug 8, 2024

Conversation

mquhuy
Copy link
Member

@mquhuy mquhuy commented Aug 6, 2024 •
edited
Loading

This assumes metal3-io/project-infra#833 was merged, and that QUAY_IO_USERNAME and QUAY_IO_TOKEN secrets exist, for pushing the image to quay.io.

An example of complete workflow (except for the push part):
https://github.com/metal3-io/baremetal-operator/actions/runs/10280659565/job/28448467379?pr=1861

/hold to wait for the secrets.

@metal3-io-bot metal3-io-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 6, 2024
@metal3-io-bot metal3-io-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 6, 2024
@mquhuy mquhuy force-pushed the mquhuy/move-container-build-to-gh-runner branch 6 times, most recently from 029ab25 to f7c48a2 Compare August 6, 2024 12:54
@metal3-io-bot metal3-io-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 6, 2024
@mquhuy mquhuy force-pushed the mquhuy/move-container-build-to-gh-runner branch 18 times, most recently from ab36e91 to 32e3a26 Compare August 6, 2024 13:31
@tuminoid
Copy link
Member

tuminoid commented Aug 8, 2024

/cc @kashifest
Please approve this, we need to merge this to see if the push works. Secrets are not available to PRs.

@mquhuy mquhuy force-pushed the mquhuy/move-container-build-to-gh-runner branch from 034b980 to 086b4ad Compare August 8, 2024 08:17
@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 8, 2024
@kashifest
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 8, 2024
@mquhuy
Copy link
Member Author

mquhuy commented Aug 8, 2024

/unhold We have the secrets and project-infra PR inplace

@mquhuy mquhuy requested a review from tuminoid August 8, 2024 09:24
@mquhuy
Copy link
Member Author

mquhuy commented Aug 8, 2024

/unhold

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 8, 2024
@mquhuy
Copy link
Member Author

mquhuy commented Aug 8, 2024

@tuminoid Could you please re-lgtm? I accidentally force pushed this PR when I tested it upstream.

@mquhuy mquhuy force-pushed the mquhuy/move-container-build-to-gh-runner branch from 086b4ad to deecc18 Compare August 8, 2024 11:30
@mquhuy mquhuy force-pushed the mquhuy/move-container-build-to-gh-runner branch from deecc18 to 553e907 Compare August 8, 2024 11:34
tuminoid
tuminoid reviewed Aug 8, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 8, 2024
@metal3-io-bot metal3-io-bot merged commit 00ee56f into metal3-io:main Aug 8, 2024
17 checks passed
@metal3-io-bot metal3-io-bot deleted the mquhuy/move-container-build-to-gh-runner branch August 8, 2024 11:58
@mquhuy
Copy link
Member Author

mquhuy commented Aug 27, 2024

/cherry-pick release-0.5 release-0.6

@mquhuy mquhuy restored the mquhuy/move-container-build-to-gh-runner branch August 27, 2024 07:51
@mquhuy
Copy link
Member Author

mquhuy commented Aug 27, 2024

/cherry-pick release-0.5 release-0.6

@metal3-io-bot metal3-io-bot mentioned this pull request Aug 27, 2024
Merged
@metal3-io-bot
Copy link
Contributor

@mquhuy: new pull request created: #1909

In response to this:

/cherry-pick release-0.5 release-0.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot
Copy link
Contributor

@mquhuy: new pull request could not be created: failed to create pull request against metal3-io/baremetal-operator#release-0.5 from head metal3-io-bot:cherry-pick-1861-to-release-0.5: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for metal3-io-bot:cherry-pick-1861-to-release-0.5."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}

In response to this:

/cherry-pick release-0.5 release-0.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mquhuy
Copy link
Member Author

mquhuy commented Aug 27, 2024

/cherry-pick release-0.6

@metal3-io-bot
Copy link
Contributor

@mquhuy: new pull request created: #1910

In response to this:

/cherry-pick release-0.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot metal3-io-bot mentioned this pull request Aug 27, 2024
Merged
@tuminoid tuminoid deleted the mquhuy/move-container-build-to-gh-runner branch August 27, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuminoid tuminoid tuminoid left review comments

@kashifest kashifest Awaiting requested review from kashifest

@Rozzii Rozzii Awaiting requested review from Rozzii

@adilGhaffarDev adilGhaffarDev Awaiting requested review from adilGhaffarDev

@NymanRobin NymanRobin Awaiting requested review from NymanRobin

@Sunnatillo Sunnatillo Awaiting requested review from Sunnatillo

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mquhuy @tuminoid @kashifest @metal3-io-bot