-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add TLS configuration flags for CAPM3 #1041
✨ Add TLS configuration flags for CAPM3 #1041
Conversation
/hold |
main_test.go
Outdated
@@ -0,0 +1,78 @@ | |||
/* | |||
Copyright 2023 The Kubernetes Authors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Metal3 authors again.
Also the whole header looks to be formatted funny.
3ae8574
to
6e85d1e
Compare
Building manager and running
We are not supporting TLS 1.0 or TLS 1.1. |
f7fbc68
to
cdb6f3f
Compare
/test-centos-e2e-integration-main |
/test-ubuntu-integration-main |
/test-ubuntu-integration-main |
1 similar comment
/test-ubuntu-integration-main |
cdb6f3f
to
458718f
Compare
/test-ubuntu-integration-main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/unhold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lentzi90, tuminoid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-1.4 |
@tuminoid: #1041 failed to apply on top of branch "release-1.4":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Added tls configuration flags for CAPM3.
This enables flags --tls-min-version and --tls-max-version flags, which can be used to limit TLS versions server accepts. Choices are TLS12 and TLS13, so you can force TLS 1.2 only, TLS 1.3 only, or (default) TLS 1.2 and TLS 1.3 is negotiated between server and client.
This also disables TLS 1.0 and TLS 1.1 as they're insecure and obsolete and not supported by Go TLS library.