Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add TLS configuration flags for CAPM3 #1041

Merged

Conversation

as20203
Copy link
Member

@as20203 as20203 commented Jun 14, 2023

Added tls configuration flags for CAPM3.

This enables flags --tls-min-version and --tls-max-version flags, which can be used to limit TLS versions server accepts. Choices are TLS12 and TLS13, so you can force TLS 1.2 only, TLS 1.3 only, or (default) TLS 1.2 and TLS 1.3 is negotiated between server and client.

This also disables TLS 1.0 and TLS 1.1 as they're insecure and obsolete and not supported by Go TLS library.

@metal3-io-bot metal3-io-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 14, 2023
@as20203 as20203 changed the title Added tls configuration flags for CAPM3. ✨ Add TLS configuration flags for CAPM3 Jun 14, 2023
@as20203
Copy link
Member Author

as20203 commented Jun 14, 2023

/hold

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 14, 2023
main_test.go Outdated
@@ -0,0 +1,78 @@
/*
Copyright 2023 The Kubernetes Authors.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metal3 authors again.

Also the whole header looks to be formatted funny.

@as20203 as20203 force-pushed the jawad/capm3-tls-configuration-flags branch 3 times, most recently from 3ae8574 to 6e85d1e Compare June 15, 2023 13:00
@tuminoid
Copy link
Member

Building manager and running ./bin/manager --help says:

  -tls-max-version string
    	The maximum TLS version in use by the webhook server.
    	Possible values are VersionTLS10, VersionTLS11, VersionTLS12, VersionTLS13. (default "VersionTLS13")
  -tls-min-version string
    	The minimum TLS version in use by the webhook server.
    	Possible values are VersionTLS10, VersionTLS11, VersionTLS12, VersionTLS13. (default "VersionTLS12")

We are not supporting TLS 1.0 or TLS 1.1.

@as20203 as20203 force-pushed the jawad/capm3-tls-configuration-flags branch 2 times, most recently from f7fbc68 to cdb6f3f Compare June 21, 2023 11:35
@as20203
Copy link
Member Author

as20203 commented Jun 21, 2023

/test-centos-e2e-integration-main

@as20203
Copy link
Member Author

as20203 commented Jun 21, 2023

/test-ubuntu-integration-main

@as20203
Copy link
Member Author

as20203 commented Jun 21, 2023

/test-ubuntu-integration-main
/test-centos-e2e-integration-main

1 similar comment
@tuminoid
Copy link
Member

/test-ubuntu-integration-main
/test-centos-e2e-integration-main

main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
@as20203 as20203 force-pushed the jawad/capm3-tls-configuration-flags branch from cdb6f3f to 458718f Compare June 22, 2023 10:56
@tuminoid
Copy link
Member

/test-ubuntu-integration-main
/test-centos-e2e-integration-main

Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2023
@tuminoid
Copy link
Member

/unhold
/assign @mboukhalfa @lentzi90

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 26, 2023
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90, tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2023
@metal3-io-bot metal3-io-bot merged commit 9e01950 into metal3-io:main Jun 26, 2023
@tuminoid
Copy link
Member

/cherry-pick release-1.4

@ghost
Copy link

ghost commented Jun 26, 2023

@tuminoid: #1041 failed to apply on top of branch "release-1.4":

Applying: Added tls configuration flags for CAPM3.
Using index info to reconstruct a base tree...
M	main.go
Falling back to patching base and 3-way merge...
Auto-merging main.go
CONFLICT (content): Merge conflict in main.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Added tls configuration flags for CAPM3.
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants