Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Introduce ReconcileError with Transient and Terminal Error type #1089

Merged
merged 1 commit into from
Jul 18, 2023
Merged

🌱 Introduce ReconcileError with Transient and Terminal Error type #1089

merged 1 commit into from
Jul 18, 2023

Conversation

Sunnatillo
Copy link
Member

Manual backport of #910 to release 1.4

@metal3-io-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@metal3-io-bot metal3-io-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 12, 2023
@Sunnatillo Sunnatillo marked this pull request as ready for review July 12, 2023 13:34
@metal3-io-bot metal3-io-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 12, 2023
@Sunnatillo
Copy link
Member Author

/test-ubuntu-e2e-integration-release-1-4

@Sunnatillo
Copy link
Member Author

/test-e2e-1-26-1-27-upgrade-release-1-4

@Sunnatillo Sunnatillo mentioned this pull request Jul 12, 2023
Closed
@Sunnatillo
Copy link
Member Author

/test build

@Sunnatillo
Copy link
Member Author

/test-e2e-1-26-1-27-upgrade-release-1-4

@Sunnatillo
Copy link
Member Author

/test build

@mboukhalfa
Copy link
Member

/approve

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 14, 2023
@Sunnatillo
Copy link
Member Author

/test build

smoshiur1237
smoshiur1237 previously approved these changes Jul 17, 2023
View reviewed changes
Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 17, 2023
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboukhalfa, smoshiur1237

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Sunnatillo
Copy link
Member Author

/test build

1 similar comment
@Sunnatillo
Copy link
Member Author

/test build

@Sunnatillo
Copy link
Member Author

/retest

@Sunnatillo
Copy link
Member Author

/test build

@Sunnatillo
Copy link
Member Author

/test all

@Sunnatillo Sunnatillo force-pushed the backport-improve-error-handling-to-release-1.4/sunnat branch from ecd4b65 to 311e322 Compare July 18, 2023 12:52
@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 18, 2023
@Sunnatillo
Introduce ReconcileError with Transient and Terminal Error type
babf27a 
Remove RequeueAfterError(depricated in CAPI)
Remove repetative error setting on m3Machine
@Sunnatillo Sunnatillo force-pushed the backport-improve-error-handling-to-release-1.4/sunnat branch from 311e322 to babf27a Compare July 18, 2023 13:06
@Sunnatillo
Copy link
Member Author

/test-ubuntu-e2e-integration-release-1-4

1 similar comment
@Sunnatillo
Copy link
Member Author

/test-ubuntu-e2e-integration-release-1-4

smoshiur1237
smoshiur1237 reviewed Jul 18, 2023
View reviewed changes
Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 18, 2023
@metal3-io-bot metal3-io-bot merged commit 90fda08 into metal3-io:release-1.4 Jul 18, 2023
@Sunnatillo Sunnatillo deleted the backport-improve-error-handling-to-release-1.4/sunnat branch July 31, 2023 20:49
@tuminoid tuminoid changed the title ✨Introduce ReconcileError with Transient and Terminal Error type 🌱 Introduce ReconcileError with Transient and Terminal Error type Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoshiur1237 smoshiur1237 smoshiur1237 left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Sunnatillo @metal3-io-bot @mboukhalfa @smoshiur1237