Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 add KUBECTL_SHA256 passthru for upgrade tests #1178

Merged
merged 1 commit into from
Sep 4, 2023
Merged

🌱 add KUBECTL_SHA256 passthru for upgrade tests #1178

merged 1 commit into from
Sep 4, 2023

Conversation

tuminoid
Copy link
Member

@tuminoid tuminoid commented Sep 4, 2023

Pass thru KUBECTL_SHA256 from JJB / project-infra to dev-env for upgrade e2e tests where k8s version is not default.

@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 4, 2023
@tuminoid
Copy link
Member Author

tuminoid commented Sep 4, 2023

/hold
WIP

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 4, 2023
@tuminoid
Copy link
Member Author

tuminoid commented Sep 4, 2023

/test-ubuntu-integration-main

@tuminoid tuminoid force-pushed the tuomo/sha256-passhtru-for-upgrades branch from b984564 to 4af2595 Compare September 4, 2023 07:59
@tuminoid
Copy link
Member Author

tuminoid commented Sep 4, 2023

/test-ubuntu-integration-main

1 similar comment
@tuminoid
Copy link
Member Author

tuminoid commented Sep 4, 2023

/test-ubuntu-integration-main

@tuminoid
Copy link
Member Author

tuminoid commented Sep 4, 2023

/test-centos-e2e-integration-main

1 similar comment
@tuminoid
Copy link
Member Author

tuminoid commented Sep 4, 2023

/test-centos-e2e-integration-main

@tuminoid
Copy link
Member Author

tuminoid commented Sep 4, 2023 

fatal: https://storage.googleapis.com/kubernetes-release/release/v1.28.0/bin/linux/amd64/kubectl binary checksum '4717660fd1466ec72d59000bb1d9f5cdc91fac31d491043ca62b34398e0799ce' differs from expected checksum 'this_is_expected_failure_for_testing'

Test worked as expected. Non E2E passes with garbage SHA though because we don't validate existing binary if the version already is installed. I'll put the real values back, and let's get this merged.

@tuminoid
add KUBECTL_SHA256 export for upgrade tests
8f2cf16 
Pass thru KUBECTL_SHA256 from JJB for upgrade e2e tests.
@tuminoid tuminoid force-pushed the tuomo/sha256-passhtru-for-upgrades branch from 4af2595 to 8f2cf16 Compare September 4, 2023 08:27
@tuminoid
Copy link
Member Author

tuminoid commented Sep 4, 2023

/unhold

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 4, 2023
@tuminoid
Copy link
Member Author

tuminoid commented Sep 4, 2023

/test-centos-e2e-integration-main
/test-ubuntu-integration-main

Sunnatillo
Sunnatillo approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 4, 2023
lentzi90
lentzi90 reviewed Sep 4, 2023
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 4, 2023
@tuminoid
Copy link
Member Author

tuminoid commented Sep 4, 2023

/test-centos-e2e-integration-main
/test-ubuntu-integration-main

@tuminoid tuminoid mentioned this pull request Sep 4, 2023
Merged
@Sunnatillo
Copy link
Member

/test-centos-e2e-integration-main

mboukhalfa
mboukhalfa approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@mboukhalfa mboukhalfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90, mboukhalfa, Sunnatillo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [lentzi90,mboukhalfa]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot merged commit d2512e1 into metal3-io:main Sep 4, 2023
13 of 14 checks passed
@tuminoid tuminoid deleted the tuomo/sha256-passhtru-for-upgrades branch September 4, 2023 12:03
tuminoid added a commit to Nordix/cluster-api-provider-metal3 that referenced this pull request Sep 5, 2023
@tuminoid
add KUBECTL_SHA256 export for upgrade tests
df392a5 
Pass thru KUBECTL_SHA256 from JJB for upgrade e2e tests.

Cherry-pick of metal3-io#1178.
This was referenced Sep 5, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lentzi90 lentzi90 lentzi90 left review comments

@mboukhalfa mboukhalfa mboukhalfa approved these changes

@Sunnatillo Sunnatillo Sunnatillo approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tuminoid @Sunnatillo @metal3-io-bot @lentzi90 @mboukhalfa