Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 fix module printout in hack/verify-release.sh #1246

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

tuminoid
Copy link
Member

@tuminoid tuminoid commented Oct 5, 2023

In case module group versions mismatch, grep failed to print out the mismatching modules. Fix the grep with "-E", and remove unnecessary curlys around it as well, after grep was optimized.

In case module group versions mismatch, grep failed to print out the
mismatching modules. Fix the grep with "-E", and remove unnecessary
curlys around it as well, after grep was optimized.
@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 5, 2023
@tuminoid
Copy link
Member Author

tuminoid commented Oct 5, 2023

/override test-centos-e2e-integration-main
/override test-ubuntu-integration-main

Save the trees.

@metal3-io-bot
Copy link
Contributor

@tuminoid: Overrode contexts on behalf of tuminoid: test-centos-e2e-integration-main, test-ubuntu-integration-main

In response to this:

/override test-centos-e2e-integration-main
/override test-ubuntu-integration-main

Save the trees.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tuminoid
Copy link
Member Author

tuminoid commented Oct 5, 2023

/cherry-pick release-1.5
/cherry-pick release-1.4

@ghost
Copy link

ghost commented Oct 5, 2023

@tuminoid: once the present PR merges, I will cherry-pick it on top of release-1.5 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.5
/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 5, 2023
@tuminoid
Copy link
Member Author

tuminoid commented Oct 5, 2023

/cc @kashifest

Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 5, 2023
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90, smoshiur1237

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot merged commit 206a354 into metal3-io:main Oct 5, 2023
14 checks passed
@metal3-io-bot metal3-io-bot deleted the tuomo/fix-verify-release branch October 5, 2023 09:52
@ghost
Copy link

ghost commented Oct 5, 2023

@tuminoid: new pull request created: #1247

In response to this:

/cherry-pick release-1.5
/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ghost
Copy link

ghost commented Oct 5, 2023

@tuminoid: new pull request created: #1248

In response to this:

/cherry-pick release-1.5
/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants