Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Remove duplicate healthcheck test trigger file #1308

Merged
merged 1 commit into from
Nov 16, 2023
Merged

🌱 Remove duplicate healthcheck test trigger file #1308

merged 1 commit into from
Nov 16, 2023

Conversation

mboukhalfa
Copy link
Member

healthcheck test is called from remediation_based_feature_test.go the file healthcheck_test.go is not needed

@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 3, 2023
@mboukhalfa
Copy link
Member Author

/test-ubuntu-e2e-feature-main

1 similar comment
@mboukhalfa
Copy link
Member Author

/test-ubuntu-e2e-feature-main

lentzi90
lentzi90 reviewed Nov 7, 2023
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense
/approve

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2023
smoshiur1237
smoshiur1237 approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90, smoshiur1237

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2023
@mboukhalfa
Copy link
Member Author

/keep-test-ubuntu-e2e-feature-main

1 similar comment
@mboukhalfa
Copy link
Member Author

/keep-test-ubuntu-e2e-feature-main

@tuminoid
Copy link
Member

/test-ubuntu-e2e-feature-main

4 similar comments
@mboukhalfa
Copy link
Member Author

/test-ubuntu-e2e-feature-main

@mboukhalfa
Copy link
Member Author

/test-ubuntu-e2e-feature-main

@mboukhalfa
Copy link
Member Author

/test-ubuntu-e2e-feature-main

@mboukhalfa
Copy link
Member Author

/test-ubuntu-e2e-feature-main

@tuminoid
Copy link
Member

/test-centos-e2e-integration-main
/test-ubuntu-integration-main

@tuminoid
Copy link
Member

/override keep-test-ubuntu-e2e-feature-main
Non required keep test.

@metal3-io-bot
Copy link
Contributor

@tuminoid: Overrode contexts on behalf of tuminoid: keep-test-ubuntu-e2e-feature-main

In response to this:

/override keep-test-ubuntu-e2e-feature-main
Non required keep test.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot metal3-io-bot merged commit 9e6c735 into metal3-io:main Nov 16, 2023
18 checks passed
@metal3-io-bot metal3-io-bot deleted the remove-duplicate-healthcheck-trigger/mohammed branch November 16, 2023 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lentzi90 lentzi90 lentzi90 left review comments

@smoshiur1237 smoshiur1237 smoshiur1237 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mboukhalfa @metal3-io-bot @tuminoid @lentzi90 @smoshiur1237