-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Bump cluster-api to v1.6.0 #1341
Conversation
694b0b8
to
f955b14
Compare
/test-centos-e2e-integration-main |
f955b14
to
1d06f65
Compare
1d06f65
to
75e703f
Compare
75e703f
to
f6d8b52
Compare
/test-centos-e2e-integration-main |
1 similar comment
/test-centos-e2e-integration-main |
/test-ubuntu-e2e-feature-main |
1 similar comment
/test-ubuntu-e2e-feature-main |
/test-centos-e2e-integration-main |
3 similar comments
/test-centos-e2e-integration-main |
/test-centos-e2e-integration-main |
/test-centos-e2e-integration-main |
ffafad9
to
245b921
Compare
/test-centos-e2e-integration-main |
1 similar comment
/test-centos-e2e-integration-main |
245b921
to
6e806ae
Compare
/keep-test-centos-e2e-integration-main |
1 similar comment
/keep-test-centos-e2e-integration-main |
ea71dcc
to
7f1366b
Compare
/keep-test-centos-e2e-integration-main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
3ab1905
to
7078ce5
Compare
7078ce5
to
ba0dbfc
Compare
/test-ubuntu-integration-main |
/test-centos-e2e-integration-main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: furkatgofurov7, lentzi90, Rozzii, smoshiur1237 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@kashifest can you rebase the PR? |
Signed-off-by: Kashif Khan <[email protected]>
ba0dbfc
to
f067b5b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold cancel |
/test-centos-e2e-integration-main |
1 similar comment
/test-centos-e2e-integration-main |
As the title says. It follows the kubernetes-sigs/cluster-api#9264 PR as suggested by CAPI book here https://main.cluster-api.sigs.k8s.io/developer/providers/migrations/v1.5-to-v1.6#suggested-changes-for-providers
Copying from CAPI PR Description:
Changes to flags
deprecate
--metrics-bind-addr
flagadd new flag
--diagnostics-address
(default: :8443)add new flag
--insecure-diagnostics
(default: false)With the following behavior
If
--metrics-bind-addr=<addr>
is set:If
--diagnostics-address=<addr>
--insecure-diagnostics
is set--metrics-bind-addr
If
--diagnostics-address
is setDefault behavior:
controller binary:
--metrics-bind-addr
set: insecure serving on the specified address (as before)published component YAMLs:
CAPM3_DIAGNOSTICS_ADDRESS=localhost:8080
&CAPM3_INSECURE_DIAGNOSTICS=true
: insecure serving onlocalhost:8080