⚠️ Stop serving v1alpha5 API Versions

[kashifest]

Set v1alpha5 API types unserved and deprecated in CRDs

Part of #971

[kashifest]

This PR follows CAPI's PR which had stopped serving v1a4 API kubernetes-sigs/cluster-api#8996. In that PR, CAPI has also dropped e2e upgrade tests from v1a4. For us, I couldn't find a simple way to drop it since they test seemed a bit convoluted to me because of parameterisation. That can be done as a followup after discussion.

[kashifest]

/retest

[kashifest]

/test-ubuntu-integration-main
/test-centos-e2e-integration-main

[lentzi90]

/approve

Just noting for the future, that it would be nicer to set the deprecation notice at least one release before stop serving. I.e. we could have set deprecation in v1.5.

[metal3-io-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [lentzi90]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tuminoid]

/approve

Just noting for the future, that it would be nicer to set the deprecation notice at least one release before stop serving. I.e. we could have set deprecation in v1.5.

We have deprecation notice in 1.5.0: https://github.com/metal3-io/cluster-api-provider-metal3/releases/tag/v1.5.0

[tuminoid]

LGTM.

/cc @mboukhalfa

[lentzi90]

We have deprecation notice in 1.5.0: https://github.com/metal3-io/cluster-api-provider-metal3/releases/tag/v1.5.0

Good! I was more thinking about the // +kubebuilder:deprecatedversion comments though. They would mark the API as deprecated also in Kubernetes and pop warnings when you use it.

[tuminoid]

We have deprecation notice in 1.5.0: https://github.com/metal3-io/cluster-api-provider-metal3/releases/tag/v1.5.0

Good! I was more thinking about the // +kubebuilder:deprecatedversion comments though. They would mark the API as deprecated also in Kubernetes and pop warnings when you use it.

Oh yes, that would be nice in the future. The deprecation notice in release notes is not visible in the repo at all, only in the notes if you know to look, so it would also provide that information.

[tuminoid]

/lgtm