Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Bump CAPI to v1.6.1 #1406

Merged
merged 1 commit into from
Jan 17, 2024
Merged

🌱 Bump CAPI to v1.6.1 #1406

merged 1 commit into from
Jan 17, 2024

Conversation

Sunnatillo
Copy link
Member

as title

@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 16, 2024
@Sunnatillo
Copy link
Member Author

/test-centos-e2e-integration-main
/test-ubuntu-integration-main

tuminoid
tuminoid reviewed Jan 17, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2024
@tuminoid
Copy link
Member

Cherry-pick to 1.6 branch?

kashifest
kashifest requested changes Jan 17, 2024
View reviewed changes
README.md Outdated
@@ -47,7 +47,7 @@ need to be manually installed. Example flow of installing Metal3 provider:
level of the logging verbose with a positive integer number, ie. -v5.

```shell
clusterctl init --core cluster-api:v1.6.0 --bootstrap kubeadm:v1.6.0 \
clusterctl init --core cluster-api:v1.6.1 --bootstrap kubeadm:v1.6.0 \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
clusterctl init --core cluster-api:v1.6.1 --bootstrap kubeadm:v1.6.0 \
clusterctl init --core cluster-api:v1.6.1 --bootstrap kubeadm:v1.6.1 \
--control-plane kubeadm:v1.6.1 -v5

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@Sunnatillo
Bump CAPI to v1.6.1
d525cf8 
Signed-off-by: Sunnatillo <[email protected]>
@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2024
@Sunnatillo
Copy link
Member Author

/test-centos-e2e-integration-main
/test-ubuntu-integration-main

@kashifest
Copy link
Member

/approve

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2024
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tuminoid
tuminoid reviewed Jan 17, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/test-centos-e2e-integration-main
/test-ubuntu-integration-main

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2024
@tuminoid
Copy link
Member

/test-centos-e2e-integration-main
/test-ubuntu-integration-main
Wakey wakey ...

@metal3-io-bot metal3-io-bot merged commit 0086dad into metal3-io:main Jan 17, 2024
19 checks passed
@metal3-io-bot metal3-io-bot deleted the uplift-capi-v1.6.1/sunnat branch January 17, 2024 09:08
@Sunnatillo
Copy link
Member Author

/cherry-pick release-1.6

@metal3-io-bot
Copy link
Contributor

@Sunnatillo: new pull request created: #1410

In response to this:

/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot metal3-io-bot mentioned this pull request Jan 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuminoid tuminoid tuminoid left review comments

@kashifest kashifest kashifest approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Sunnatillo @tuminoid @kashifest @metal3-io-bot