Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Default k8s version in ensure-kubectl script #1432

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

kashifest
Copy link
Member

@kashifest kashifest commented Jan 29, 2024

If we don't default to the kubernetes version used for the test, it will always use v1.29.0 and it will error out for upgrade tests where we use older k8s version to begin with.

@metal3-io-bot metal3-io-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 29, 2024
@kashifest
Copy link
Member Author

/test-e2e-1-27-1-28-upgrade-main

@kashifest
Copy link
Member Author

/test-e2e-1-26-1-27-upgrade-main

@kashifest
Copy link
Member Author

/test-e2e-1-27-1-28-upgrade-main
/test-e2e-1-26-1-27-upgrade-main
/test-e2e-1-28-1-29-upgrade-main

@kashifest
Copy link
Member Author

/test-centos-e2e-integration-main
/test-ubuntu-integration-main

@kashifest
Copy link
Member Author

/test-e2e-1-27-1-28-upgrade-main
/test-e2e-1-26-1-27-upgrade-main
/test-e2e-1-28-1-29-upgrade-main

@kashifest
Copy link
Member Author

/test-centos-e2e-integration-main
/test-ubuntu-integration-main

@kashifest kashifest changed the title WIP: 🐛 Default k8s version in ensure-kubectl script 🐛 Default k8s version in ensure-kubectl script Jan 29, 2024
@metal3-io-bot metal3-io-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 29, 2024
Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2024
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90, smoshiur1237

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2024
@metal3-io-bot metal3-io-bot merged commit 7436932 into metal3-io:main Jan 29, 2024
33 checks passed
@metal3-io-bot metal3-io-bot deleted the default/k8s-version-kubectl branch January 29, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants