-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Fix Permission Issue for process.txt in Tiltfile Configuration #1436
Conversation
Q: non-root as in host side, or container side? For container side non-root we remove the securityContexts for Tilt, so it runs as root for Tilt development. |
Could you explain the commit message a little bit more? I'm having a hard time matching the description there with what gets changed. |
I am also having difficulties to understand the commit message and the changes. Also It seems to run as root. |
3a8e6c4
to
f4a8807
Compare
I have now updated the Title, commit message and explanation. I totally understand your confusion and the lack of explanation. @mquhuy & @smoshiur1237 thanks for pointing that out. It was a mistake from my side, an earlier commit message was hanging. @tuminoid I'm not sure if it is container-side or host. I have notice what you mentioned about bypassing the securityContexts and that is something I will try to change next, so we are more similar to the CAPI setup. I got this error when trying to start up tilt: |
Signed-off-by: Max Rantil <[email protected]>
f4a8807
to
2e6d2e0
Compare
OK, so the issue is that the |
/override test-centos-e2e-integration-main test-ubuntu-integration-main |
@tuminoid: Overrode contexts on behalf of tuminoid: test-centos-e2e-integration-main, test-ubuntu-integration-main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Not sure if I understood what we are trying to do here but lets see if it helps. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kashifest The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR fixes a setup issue:
start.sh: line 34: can't create process.txt: Permission denied
. Modifications in the Tiltfile ensure process.txt is now correctly created with full permissions (0777).