Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Remove ironic-inspector from container list for e2e tests #1487

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

kashifest
Copy link
Member

Some leftovers were still there even after #1483 and #1481, which is only caught in feature test.

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 1, 2024
@kashifest
Copy link
Member Author

/test-centos-e2e-integration-main
/test-centos-e2e-feature-main
/test-ubuntu-e2e-feature-main
/test-ubuntu-integration-main

Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 1, 2024
@kashifest
Copy link
Member Author

/test-centos-e2e-feature-main
/test-ubuntu-e2e-feature-main

@kashifest
Copy link
Member Author

/test-ubuntu-e2e-feature-main

Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2024
@metal3-io-bot metal3-io-bot merged commit 3e25dbd into metal3-io:main Mar 4, 2024
19 checks passed
@metal3-io-bot metal3-io-bot deleted the remove/inspector branch March 4, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants