Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 support beta and rc releases in release note generator #1567

Merged

Conversation

tuminoid
Copy link
Member

Support beta and RC releases in release note generator. Move some logic from Makefile to the release note generator, and then add nice unfolding summary section to hide details in beta/rc notes.

Fix previous release tag pattern detection in Makefile.

Remove ironic-image related notes, as it has proper release process itself now.

Below, I'll add the output of v1.7.0-beta.0 beta output:


Changes since v1.6.1
---
## :warning: Breaking Changes
- Remove v1alpha5 API Version (#1525)

:rotating_light: This is a BETA RELEASE. Use it only for testing purposes. If you find any bugs, file an [issue](https://github.com/metal3-io/cluster-api-provider-metal3/issues/new/).

<details>
<summary>More details about the release</summary>

## :bug: Bug Fixes
- e2e: Specify ip address pool for retreiving ip for accessing node (#1528)
- bump google.golang.org/protobuf to v1.33.0 (#1508)
- EnsureImage download image fix (#1479)
- Fix for kubectl version command for different versions of k8s (#1433)
- Default k8s version in ensure-kubectl script (#1432)
- Install ginkgo directly instead of building it using go-modules (#1415)
- Fix for v1.6 clusterctl upgrade. (#1400)

## :book: Documentation
- switch markdownlint container to markdownlint-cli2 (#1414)
- Update Support matrix in Contributing guide (#1409)

## :seedling: Others
- Bump github.com/onsi/ginkgo/v2 from 2.17.0 to 2.17.1 in /test (#1566)
- Bump github.com/onsi/ginkgo/v2 from 2.17.0 to 2.17.1 (#1565)
- Bump cert-manager version v1.13.0 -> v1.14.0 (#1559)
- Uplift ipam 1.7.0-beta.0 release (#1562)
- Fix: Metal3Data Manager log levels (#1558)
- Simplifying and updating clusterctl upgrade tests (#1452)
- remove redundant make targets and scripts (#1561)
- Bump docker go module to v26.0.0 (#1560)
- Bump CAPI to v1.7.0-beta.0 (#1530)
- Bump github.com/docker/docker from 24.0.7+incompatible to 24.0.9+incompatible in /test (#1556)
- Bump github.com/onsi/ginkgo/v2 from 2.16.0 to 2.17.0 (#1534)
- Bump github.com/onsi/gomega from 1.31.1 to 1.32.0 (#1538)
- Bump github.com/onsi/ginkgo/v2 from 2.16.0 to 2.17.0 in /test (#1542)
- bump k8s.io deps to v0.29.3 (#1543)
- Update basic e2e trigger on README.md (#1493)
- Remove release-1.2 upgrade test description from README (#1529)
- Bump golang to v1.21.8 (#1520)
- add golang base image check to verify-release.sh (#1516)
- Bump golang.org/x/net from 0.21.0 to 0.22.0 (#1519)
- Bump github.com/metal3-io/baremetal-operator/apis from 0.5.0 to 0.5.1 (#1518)
- Bump github.com/metal3-io/baremetal-operator/apis from 0.5.0 to 0.5.1 in /test (#1517)
- bump shellcheck to v0.10.0 (#1509)
- Add labels on e2e tests (#1502)
- Bump github.com/onsi/ginkgo/v2 from 2.15.0 to 2.16.0 in /test (#1505)
- Bump github.com/onsi/ginkgo/v2 from 2.15.0 to 2.16.0 (#1506)
- Bump golang.org/x/crypto from 0.20.0 to 0.21.0 in /test (#1504)
- Bump golangci-lint to v1.56.2 (#1503)
- Revert "try fix GH workflow for build images" (#1494)
- Remove ironic-inspector from container list for e2e tests (#1487)
- Bump golangci/golangci-lint-action from 3.7.0 to 4.0.0 (#1491)
- Bump github/codeql-action from 3.23.2 to 3.24.6 (#1490)
- Bump actions/cache from 4.0.0 to 4.0.1 (#1489)
- try fix GH workflow for image building (#1488)
- Remove ironic-inspector from container list for ubuntu e2e tests (#1483)
- E2E: Remove inspector container (#1481)
- Bump golang to v1.21.7 (#1476)
- Bump golang.org/x/crypto from 0.19.0 to 0.20.0 in /test (#1470)
- Bump CAPI to v1.6.2 (#1467)
- Bump the kubernetes group with 2 updates (#1462)
- Bump the kubernetes group in /test with 1 update (#1463)
- Bump k8s.io/code-generator from 0.29.1 to 0.29.2 in /hack/tools (#1457)
- Bump sigs.k8s.io/controller-runtime from 0.17.1 to 0.17.2 in /api (#1456)
- Bump the kubernetes group in /api with 3 updates (#1455)
- Enable more linters for golangci-lint (#1443)
- Bump golang.org/x/net from 0.20.0 to 0.21.0 (#1450)
- Bump controller-runtime to v0.17.1 (#1444)
- Bump github/codeql-action from 3.22.12 to 3.23.2 (#1440)
- Bump actions/cache from 3.3.2 to 4.0.0 (#1439)
- Bump EndBug/add-and-commit from 9.1.3 to 9.1.4 (#1438)
- Fix Permission Issue for process.txt in Tiltfile Configuration (#1436)
- Bump golang to v1.21.6 (#1435)
- Bump k8s.io/code-generator from 0.29.0 to 0.29.1 in /hack/tools (#1416)
- Bump github.com/onsi/gomega from 1.30.0 to 1.31.1 (#1424)
- bump k8s.io/* deps to v0.28.6 (#1430)
- Add ginkgo phony in Makefile (#1412)
- Bump envtest to v1.29.x (#1411)
- Bump CAPI to v1.6.1 (#1406)
- bump ginkgo to v2.14.0 (#1403)
- Bump k8s to v1.29.0 (#1399)
- reduce github actions permissions (#1386)
- remove release-1.3 (#1397)
- Add github action to trigger container image build (#1338)
- Bump github.com/go-logr/logr from 1.3.0 to 1.4.1 (#1376)
- bump golang to 1.20.12 (#1392)
- Bump golang.org/x/net from 0.19.0 to 0.20.0 (#1389)

</details>

The image for this release is: v1.7.0-beta.0
Mariadb image tag is capm3-v1.7.0-beta.0

_Thanks to all our contributors!_ 😊

@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 26, 2024
@tuminoid
Copy link
Member Author

/cc @adilGhaffarDev @kashifest @mquhuy

@adilGhaffarDev
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2024
Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Support beta and RC releases in release note generator. Move some
logic from Makefile to the release note generator, and then add nice
unfolding summary section to hide details in beta/rc notes.

Fix previous release tag pattern detection in Makefile.

Signed-off-by: Tuomo Tanskanen <[email protected]>
@tuminoid tuminoid force-pushed the tuomo/fix-release-note-generator branch from c5b2cd2 to 55418b3 Compare March 26, 2024 09:01
@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2024
@tuminoid
Copy link
Member Author

New changes are detected. LGTM label has been removed.

Fixed the warning template var name to be Go style.

@adilGhaffarDev
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2024
Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2024
@tuminoid
Copy link
Member Author

/override test-centos-e2e-integration-main test-ubuntu-integration-main

@metal3-io-bot
Copy link
Contributor

@tuminoid: Overrode contexts on behalf of tuminoid: test-centos-e2e-integration-main, test-ubuntu-integration-main

In response to this:

/override test-centos-e2e-integration-main test-ubuntu-integration-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot metal3-io-bot merged commit 299c514 into metal3-io:main Mar 26, 2024
17 checks passed
@metal3-io-bot metal3-io-bot deleted the tuomo/fix-release-note-generator branch March 26, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants