Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 update releasing doc #1570

Merged
merged 1 commit into from
Mar 28, 2024
Merged

📖 update releasing doc #1570

merged 1 commit into from
Mar 28, 2024

Conversation

tuminoid
Copy link
Member

Update releasing doc to be more clear, update the container build process to match current workflow, highlight the verify-release.sh usage more, add mentions on the beta and RC releases.

@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 26, 2024
@tuminoid
Copy link
Member Author

/hold
for sufficient review from release team.

/cc @adilGhaffarDev @mquhuy @kashifest @smoshiur1237

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 26, 2024
@tuminoid tuminoid force-pushed the tuomo/update-releasing-doc branch 2 times, most recently from 0a9a6c1 to ca15fb6 Compare March 26, 2024 14:12
mquhuy
mquhuy reviewed Mar 27, 2024
View reviewed changes
Copy link
Member

@mquhuy mquhuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Tuomo. This looks very good to me already, just some minor suggestion

docs/releasing.md Show resolved Hide resolved
@tuminoid tuminoid requested a review from mquhuy March 27, 2024 12:01
@metal3-io-bot metal3-io-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 27, 2024
@tuminoid
Copy link
Member Author

Updated per suggesions, please recheck @mquhuy .

@tuminoid
Copy link
Member Author

/unhold
/assign @kashifest

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 27, 2024
@tuminoid
Copy link
Member Author

/override test-centos-e2e-integration-main test-ubuntu-integration-main

@metal3-io-bot
Copy link
Contributor

@tuminoid: Overrode contexts on behalf of tuminoid: test-centos-e2e-integration-main, test-ubuntu-integration-main

In response to this:

/override test-centos-e2e-integration-main test-ubuntu-integration-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

smoshiur1237
smoshiur1237 reviewed Mar 27, 2024
View reviewed changes
Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. It is more understandable than the previous version. For me it is in good shape.
/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2024
kashifest
kashifest reviewed Mar 27, 2024
View reviewed changes
Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

One suggestion inline

docs/releasing.md Outdated Show resolved Hide resolved
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2024
@kashifest
Copy link
Member

/hold

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 27, 2024
@kashifest
Copy link
Member

Fell free to unhold when you are ready

@tuminoid
update releasing doc
71bef41 
Update releasing doc to be more clear, update the container build
process to match current workflow, highlight the verify-release.sh
usage more etc.

Signed-off-by: Tuomo Tanskanen <[email protected]>
@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2024
@tuminoid
Copy link
Member Author

/unhold

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 27, 2024
@tuminoid
Copy link
Member Author

/override test-centos-e2e-integration-main test-ubuntu-integration-main

@metal3-io-bot
Copy link
Contributor

@tuminoid: Overrode contexts on behalf of tuminoid: test-centos-e2e-integration-main, test-ubuntu-integration-main

In response to this:

/override test-centos-e2e-integration-main test-ubuntu-integration-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tuminoid tuminoid mentioned this pull request Mar 28, 2024
Merged
smoshiur1237
smoshiur1237 reviewed Mar 28, 2024
View reviewed changes
Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2024
@metal3-io-bot metal3-io-bot merged commit 291b56b into metal3-io:main Mar 28, 2024
12 checks passed
@metal3-io-bot metal3-io-bot deleted the tuomo/update-releasing-doc branch March 28, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoshiur1237 smoshiur1237 smoshiur1237 left review comments

@kashifest kashifest kashifest left review comments

@adilGhaffarDev adilGhaffarDev Awaiting requested review from adilGhaffarDev

@mquhuy mquhuy Awaiting requested review from mquhuy

Assignees

@kashifest kashifest

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tuminoid @metal3-io-bot @kashifest @mquhuy @smoshiur1237