Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Update e2e feature tests link #1572

Merged
merged 1 commit into from
Mar 27, 2024
Merged

🌱 Update e2e feature tests link #1572

merged 1 commit into from
Mar 27, 2024

Conversation

Sunnatillo
Copy link
Member

Fixes markdown check action

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 26, 2024
@Sunnatillo Sunnatillo force-pushed the fix-e2e-featute-tests-jenkins-link/sunnat branch from ca9db46 to 2ef0984 Compare March 26, 2024 17:57
@Sunnatillo
Copy link
Member Author

We should override the tests as we are only changing readme file, I do not have a permission. Please override if you have permission

tuminoid
tuminoid reviewed Mar 27, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2024
@tuminoid
Copy link
Member

/override test-centos-e2e-integration-main test-ubuntu-integration-main

We should override the tests as we are only changing readme file, I do not have a permission. Please override if you have permission

Done.

@metal3-io-bot
Copy link
Contributor

@tuminoid: Overrode contexts on behalf of tuminoid: test-centos-e2e-integration-main, test-ubuntu-integration-main

In response to this:

/override test-centos-e2e-integration-main test-ubuntu-integration-main

We should override the tests as we are only changing readme file, I do not have a permission. Please override if you have permission

Done.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tuminoid tuminoid mentioned this pull request Mar 27, 2024
Merged
@kashifest
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2024
@metal3-io-bot metal3-io-bot merged commit 61b6a40 into metal3-io:main Mar 27, 2024
12 checks passed
@metal3-io-bot metal3-io-bot deleted the fix-e2e-featute-tests-jenkins-link/sunnat branch March 27, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuminoid tuminoid tuminoid left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Sunnatillo @tuminoid @metal3-io-bot @kashifest