Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Update e2e integration triggers #1582

Merged

Conversation

mboukhalfa
Copy link
Member

Updating readme after migrating e2e integration to prow jenkins operator

@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 4, 2024
@mboukhalfa
Copy link
Member Author

/test metal3-ubuntu-e2e-integration-main

@metal3-io-bot
Copy link
Contributor

@mboukhalfa: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test build
  • /test generate
  • /test gomod
  • /test manifestlint
  • /test markdownlint
  • /test shellcheck
  • /test test
  • /test unit

The following commands are available to trigger optional jobs:

  • /test metal3-centos-e2e-basic-test-main
  • /test metal3-centos-e2e-feature-test-main
  • /test metal3-centos-e2e-integration-test-main
  • /test metal3-e2e-1-26-1-27-upgrade-test-main
  • /test metal3-e2e-1-27-1-28-upgrade-test-main
  • /test metal3-e2e-1-28-1-29-upgrade-test-main
  • /test metal3-e2e-clusterctl-upgrade-test-main
  • /test metal3-keep-clusterctl-upgrade-test-main
  • /test metal3-keep-e2e-1-26-1-27-upgrade-test-main
  • /test metal3-keep-e2e-1-27-1-28-upgrade-test-main
  • /test metal3-keep-e2e-1-28-1-29-upgrade-test-main
  • /test metal3-ubuntu-e2e-basic-test-main
  • /test metal3-ubuntu-e2e-feature-test-main
  • /test metal3-ubuntu-e2e-integration-test-main

Use /test all to run the following jobs that were automatically triggered:

  • markdownlint

In response to this:

/test metal3-ubuntu-e2e-integration-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mboukhalfa mboukhalfa force-pushed the Update-e2e-integration-triggers/mohammed branch 2 times, most recently from 243d3d8 to 1f12d2a Compare April 4, 2024 14:50
@metal3-io-bot metal3-io-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 4, 2024
@mboukhalfa
Copy link
Member Author

/test metal3-ubuntu-e2e-integration-test-main

@tuminoid
Copy link
Member

tuminoid commented Apr 5, 2024

Should the GH side required tests be updated for CAPM3 now?

Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 5, 2024
Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 5, 2024
@kashifest
Copy link
Member

Should the GH side required tests be updated for CAPM3 now?

Yes I think

@tuminoid
Copy link
Member

tuminoid commented Apr 5, 2024

OK, let's then run them here, so they appear as valid choices.

/test ?

@metal3-io-bot
Copy link
Contributor

@tuminoid: The following commands are available to trigger required jobs:

  • /test build
  • /test generate
  • /test gomod
  • /test manifestlint
  • /test markdownlint
  • /test shellcheck
  • /test test
  • /test unit

The following commands are available to trigger optional jobs:

  • /test metal3-centos-e2e-basic-test-main
  • /test metal3-centos-e2e-feature-test-main
  • /test metal3-centos-e2e-integration-test-main
  • /test metal3-e2e-1-26-1-27-upgrade-test-main
  • /test metal3-e2e-1-27-1-28-upgrade-test-main
  • /test metal3-e2e-1-28-1-29-upgrade-test-main
  • /test metal3-e2e-clusterctl-upgrade-test-main
  • /test metal3-keep-clusterctl-upgrade-test-main
  • /test metal3-keep-e2e-1-26-1-27-upgrade-test-main
  • /test metal3-keep-e2e-1-27-1-28-upgrade-test-main
  • /test metal3-keep-e2e-1-28-1-29-upgrade-test-main
  • /test metal3-ubuntu-e2e-basic-test-main
  • /test metal3-ubuntu-e2e-feature-test-main
  • /test metal3-ubuntu-e2e-integration-test-main

Use /test all to run the following jobs that were automatically triggered:

  • markdownlint

In response to this:

OK, let's then run them here, so they appear as valid choices.

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tuminoid
Copy link
Member

tuminoid commented Apr 5, 2024

/test metal3-centos-e2e-integration-test-main

I don't see anything matching test-ubuntu-integration-main ?

@tuminoid
Copy link
Member

tuminoid commented Apr 5, 2024

Also, we need a Prow job to update required tests in project-infra.

/hold

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 5, 2024
@mboukhalfa
Copy link
Member Author

/test metal3-centos-e2e-integration-test-main

I don't see anything matching test-ubuntu-integration-main ?

there is : metal3-ubuntu-e2e-integration-test-main

@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2024
@mboukhalfa
Copy link
Member Author

/test metal3-ubuntu-e2e-integration-test-main

@mboukhalfa mboukhalfa force-pushed the Update-e2e-integration-triggers/mohammed branch from 15dc218 to 3b5a538 Compare April 12, 2024 12:43
@mboukhalfa
Copy link
Member Author

/test metal3-ubuntu-e2e-integration-test-main

3 similar comments
@mboukhalfa
Copy link
Member Author

/test metal3-ubuntu-e2e-integration-test-main

@mboukhalfa
Copy link
Member Author

/test metal3-ubuntu-e2e-integration-test-main

@mboukhalfa
Copy link
Member Author

/test metal3-ubuntu-e2e-integration-test-main

@mboukhalfa mboukhalfa force-pushed the Update-e2e-integration-triggers/mohammed branch from 3b5a538 to eabfa68 Compare April 12, 2024 12:53
@mboukhalfa
Copy link
Member Author

/test metal3-ubuntu-e2e-integration-test-main

@mboukhalfa
Copy link
Member Author

/test metal3-ubuntu-e2e-integration-test-main 😯

@kashifest
Copy link
Member

Whats happening here, I can see I approved it but now you started testing with something new ? is this not ready yet

@mboukhalfa
Copy link
Member Author

/test metal3-ubuntu-e2e-integration-test-main

1 similar comment
@mboukhalfa
Copy link
Member Author

/test metal3-ubuntu-e2e-integration-test-main

@metal3-io-bot
Copy link
Contributor

metal3-io-bot commented Apr 12, 2024

@mboukhalfa: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
shellcheck eabfa68 link true /test shellcheck

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mboukhalfa mboukhalfa force-pushed the Update-e2e-integration-triggers/mohammed branch from eabfa68 to 1f12d2a Compare April 12, 2024 13:12
Signed-off-by: Mohammed Boukhalfa <[email protected]>
@mboukhalfa mboukhalfa force-pushed the Update-e2e-integration-triggers/mohammed branch from 1f12d2a to bd7bef3 Compare April 12, 2024 13:20
@mboukhalfa
Copy link
Member Author

PR to make prow required metal3-io/project-infra#698

@mboukhalfa
Copy link
Member Author

/cherry-pick release-1.6

@metal3-io-bot
Copy link
Contributor

@mboukhalfa: once the present PR merges, I will cherry-pick it on top of release-1.6 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mboukhalfa mboukhalfa closed this Apr 15, 2024
@mboukhalfa mboukhalfa reopened this Apr 15, 2024
@mboukhalfa
Copy link
Member Author

/override test-centos-e2e-integration-main
/override test-ubuntu-integration-main

@metal3-io-bot
Copy link
Contributor

@mboukhalfa: Overrode contexts on behalf of mboukhalfa: test-centos-e2e-integration-main, test-ubuntu-integration-main

In response to this:

/override test-centos-e2e-integration-main
/override test-ubuntu-integration-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mboukhalfa
Copy link
Member Author

/test ?

@metal3-io-bot
Copy link
Contributor

@mboukhalfa: The following commands are available to trigger required jobs:

  • /test build
  • /test generate
  • /test gomod
  • /test manifestlint
  • /test markdownlint
  • /test metal3-ubuntu-e2e-integration-test-main
  • /test shellcheck
  • /test test
  • /test unit

The following commands are available to trigger optional jobs:

  • /test metal3-centos-e2e-basic-test-main
  • /test metal3-centos-e2e-feature-test-main
  • /test metal3-centos-e2e-integration-test-main
  • /test metal3-e2e-1-26-1-27-upgrade-test-main
  • /test metal3-e2e-1-27-1-28-upgrade-test-main
  • /test metal3-e2e-1-28-1-29-upgrade-test-main
  • /test metal3-e2e-clusterctl-upgrade-test-main
  • /test metal3-keep-clusterctl-upgrade-test-main
  • /test metal3-keep-e2e-1-26-1-27-upgrade-test-main
  • /test metal3-keep-e2e-1-27-1-28-upgrade-test-main
  • /test metal3-keep-e2e-1-28-1-29-upgrade-test-main
  • /test metal3-ubuntu-e2e-basic-test-main
  • /test metal3-ubuntu-e2e-feature-test-main

Use /test all to run the following jobs that were automatically triggered:

  • markdownlint

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mboukhalfa
Copy link
Member Author

/test metal3-ubuntu-e2e-integration-test-main

Copy link
Member

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2024
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mboukhalfa
Copy link
Member Author

/hold cancel

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 15, 2024
@metal3-io-bot metal3-io-bot merged commit 2b721e6 into metal3-io:main Apr 15, 2024
20 checks passed
@metal3-io-bot metal3-io-bot deleted the Update-e2e-integration-triggers/mohammed branch April 15, 2024 08:35
@metal3-io-bot
Copy link
Contributor

@mboukhalfa: #1582 failed to apply on top of branch "release-1.6":

Applying: Update e2e integration triggers
Using index info to reconstruct a base tree...
M	README.md
Falling back to patching base and 3-way merge...
Auto-merging README.md
CONFLICT (content): Merge conflict in README.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Update e2e integration triggers
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants