Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Add info about k8s-upgrade tests for release branches #1608

Merged
merged 1 commit into from
May 2, 2024
Merged

📖 Add info about k8s-upgrade tests for release branches #1608

merged 1 commit into from
May 2, 2024

Conversation

Sunnatillo
Copy link
Member

This PR add documentation about k8s-upgrade tests which run on branches

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 19, 2024
@Sunnatillo Sunnatillo force-pushed the improve-k8s-upgrade-test-doc/sunnat branch 2 times, most recently from 66a0d8f to a29d006 Compare April 22, 2024 07:45
mquhuy
mquhuy previously requested changes Apr 22, 2024
View reviewed changes
Copy link
Member

@mquhuy mquhuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit

docs/e2e-test.md Outdated Show resolved Hide resolved
smoshiur1237
smoshiur1237 reviewed Apr 22, 2024
View reviewed changes
docs/e2e-test.md Outdated Show resolved Hide resolved
kashifest
kashifest reviewed Apr 24, 2024
View reviewed changes
Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2024
@Sunnatillo Sunnatillo force-pushed the improve-k8s-upgrade-test-doc/sunnat branch 2 times, most recently from 9c23071 to 826f254 Compare April 24, 2024 08:08
@Sunnatillo
Copy link
Member Author

/hold
More changes needed

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 24, 2024
@Sunnatillo Sunnatillo force-pushed the improve-k8s-upgrade-test-doc/sunnat branch from 826f254 to e5864e5 Compare April 24, 2024 10:32
@metal3-io-bot metal3-io-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 24, 2024
@Sunnatillo
Copy link
Member Author

/override metal3-centos-e2e-integration-test-main
/override metal3-ubuntu-e2e-integration-test-main

@metal3-io-bot
Copy link
Contributor

@Sunnatillo: Sunnatillo unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file.

In response to this:

/override metal3-centos-e2e-integration-test-main
/override metal3-ubuntu-e2e-integration-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Sunnatillo
Copy link
Member Author

/unhold
Changes are done

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 24, 2024
@adilGhaffarDev
Copy link
Member

/test ?

@metal3-io-bot
Copy link
Contributor

@adilGhaffarDev: The following commands are available to trigger required jobs:

  • /test build
  • /test generate
  • /test gomod
  • /test manifestlint
  • /test markdownlint
  • /test metal3-centos-e2e-integration-test-main
  • /test metal3-ubuntu-e2e-integration-test-main
  • /test shellcheck
  • /test test
  • /test unit

The following commands are available to trigger optional jobs:

  • /test metal3-centos-e2e-basic-test-main
  • /test metal3-centos-e2e-feature-test-main
  • /test metal3-e2e-1-26-1-27-upgrade-test-main
  • /test metal3-e2e-1-27-1-28-upgrade-test-main
  • /test metal3-e2e-1-28-1-29-upgrade-test-main
  • /test metal3-e2e-clusterctl-upgrade-test-main
  • /test metal3-ubuntu-e2e-basic-test-main
  • /test metal3-ubuntu-e2e-feature-test-main

Use /test all to run the following jobs that were automatically triggered:

  • markdownlint

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

smoshiur1237
smoshiur1237 reviewed Apr 25, 2024
View reviewed changes
Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2024
@Sunnatillo
Copy link
Member Author

@kashifest @mboukhalfa @tuminoid
Please override the tests

@kashifest
Copy link
Member

/hold
This needs an update after the https://gerrit.nordix.org/c/infra/cicd/+/21019 lands

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 30, 2024
@Sunnatillo Sunnatillo force-pushed the improve-k8s-upgrade-test-doc/sunnat branch from e5864e5 to 3da572a Compare May 2, 2024 10:40
@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label May 2, 2024
@Sunnatillo Sunnatillo force-pushed the improve-k8s-upgrade-test-doc/sunnat branch from 3da572a to 295e0d3 Compare May 2, 2024 10:42
@Sunnatillo
Copy link
Member Author

/hold This needs an update after the https://gerrit.nordix.org/c/infra/cicd/+/21019 lands

I updated with new version k8s v1.30

@Sunnatillo
Copy link
Member Author

Please override tests as well if you have the right

smoshiur1237
smoshiur1237 approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label May 2, 2024
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest, smoshiur1237

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@smoshiur1237
Copy link
Member

/override metal3-centos-e2e-integration-test-main
/override metal3-ubuntu-e2e-integration-test-main

@metal3-io-bot
Copy link
Contributor

@smoshiur1237: smoshiur1237 unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file.

In response to this:

/override metal3-centos-e2e-integration-test-main
/override metal3-ubuntu-e2e-integration-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@smoshiur1237
Copy link
Member

@kashifest could you please override the tests?

@lentzi90
Copy link
Member

lentzi90 commented May 2, 2024

/override metal3-centos-e2e-integration-test-main
/override metal3-ubuntu-e2e-integration-test-main

@metal3-io-bot
Copy link
Contributor

@lentzi90: Overrode contexts on behalf of lentzi90: metal3-centos-e2e-integration-test-main, metal3-ubuntu-e2e-integration-test-main

In response to this:

/override metal3-centos-e2e-integration-test-main
/override metal3-ubuntu-e2e-integration-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kashifest
kashifest reviewed May 2, 2024
View reviewed changes
Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/unhold

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 2, 2024
@kashifest
Copy link
Member

/hold cancel

@kashifest
Copy link
Member

/ok-to-test

@metal3-io-bot metal3-io-bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 2, 2024
@Sunnatillo Sunnatillo changed the title 📖 add info about k8s-upgrade tests for release branches 📖 Add info about k8s-upgrade tests for release branches May 2, 2024
@kashifest kashifest dismissed mquhuy’s stale review May 2, 2024 12:10

It has been addressed

@metal3-io-bot metal3-io-bot merged commit e1ca9fa into metal3-io:main May 2, 2024
19 checks passed
@metal3-io-bot metal3-io-bot deleted the improve-k8s-upgrade-test-doc/sunnat branch May 2, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kashifest kashifest kashifest left review comments

@adilGhaffarDev adilGhaffarDev adilGhaffarDev left review comments

@smoshiur1237 smoshiur1237 smoshiur1237 approved these changes

@mquhuy mquhuy mquhuy left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Sunnatillo @metal3-io-bot @adilGhaffarDev @kashifest @smoshiur1237 @lentzi90 @mquhuy