🐛 Clusterclass e2e test fix

[p-strusiewiczsurmacki-mobica]

This PR is a followup to #1405

It fixes issues with redundant test env related vars and configs that couses the test to fail at start. Those were removed in #1624 and should be also removed for clusterclass.

Also, it tries to fix issue with {{ ds.meta_data.hostname }}' reference reported in the comment here.

It seems that, according to the cluster-api repository, NodeRegistration.Name defaults to hostname, so I believe referencing hostname explicitly here is redundant and minght be deleted.

[metal3-io-bot]

Hi @p-strusiewiczsurmacki-mobica. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tuminoid]

/ok-to-test

[Rozzii]

/metal3-centos-e2e-integration-test-main
/lgtm

[Rozzii]

/test metal3-centos-e2e-integration-test-main
/test metal3-ubuntu-e2e-integration-test-main

[kashifest]

/approve
Thanks a lot for the fix @p-strusiewiczsurmacki-mobica

[metal3-io-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [kashifest]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kashifest]

/test metal3-centos-e2e-integration-test-main

[tuminoid]

The link to the centos e2e points to completely different PR.

Anyways, ubuntu passed,
/override metal3-centos-e2e-integration-test-main

[metal3-io-bot]

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-centos-e2e-integration-test-main

In response to this:

The link to the centos e2e points to completely different PR.

Anyways, ubuntu passed,
/override metal3-centos-e2e-integration-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.