Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Fix dependabot release branch config to bump only patch versions #1708

Merged

Conversation

kashifest
Copy link
Member

@kashifest kashifest commented May 17, 2024

With the recent introduction of release branch configuration for dependabot, it is pushing bumps for minor versions of dependancies as well. We don't want minor version bumps for release branches. Setting it to patch versions.
Signed-off-by: Kashif Khan [email protected]

@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 17, 2024
@kashifest
Copy link
Member Author

With the recent introduction of release branch configuation for dependabot, it is pushing bumps for minor versions of dependancies as well. We dont want minor version bumps for release branches. Setting it to patch versions.
Signed-off-by: Kashif Khan <[email protected]>
@kashifest kashifest force-pushed the kashif/fix-release1.7-dependabot branch from dc61587 to bc432ed Compare May 17, 2024 08:57
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2024
@kashifest
Copy link
Member Author

/override metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

@metal3-io-bot
Copy link
Contributor

@kashifest: Overrode contexts on behalf of kashifest: metal3-centos-e2e-integration-test-main, metal3-ubuntu-e2e-integration-test-main

In response to this:

/override metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label May 17, 2024
@metal3-io-bot metal3-io-bot merged commit e611f02 into metal3-io:main May 17, 2024
15 checks passed
@metal3-io-bot metal3-io-bot deleted the kashif/fix-release1.7-dependabot branch May 17, 2024 09:08
kashifest added a commit to Nordix/cluster-api-provider-metal3 that referenced this pull request May 17, 2024
…r bumps

Fixing patch version bumps via groups for release branches was probably a bad idea here metal3-io#1708. It has caused chaos and multiple different dependencies are now being grouped together in one PR. Current fix tries to tackle that by bringing back k8s group and then add an ignore rule for all dependancies in release branch to only allow patch bumps

Signed-off-by: Kashif Khan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants