Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 refactor TLS config #1724

Merged
merged 1 commit into from
May 21, 2024
Merged

🌱 refactor TLS config #1724

merged 1 commit into from
May 21, 2024

Conversation

tuminoid
Copy link
Member

TLS config code causes security linters to report false positive about TLS versions that can be configured.

This is porting over CAPO PR 2037.

@tuminoid
Copy link
Member Author

/test metal3-ubuntu-e2e-integration-test-main

@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 20, 2024
@tuminoid
refactor TLS config
2c08962 
TLS config code causes security linters to report false positive
about TLS versions that can be configured.

This is porting over CAPO PR 2037.

Signed-off-by: Tuomo Tanskanen <[email protected]>
@tuminoid
Copy link
Member Author

/test metal3-ubuntu-e2e-integration-test-main

@tuminoid
Copy link
Member Author

/override metal3-centos-e2e-integration-test-main
Centos is unstable, Ubuntu + unit passed.

/cc @mboukhalfa @lentzi90

@metal3-io-bot
Copy link
Contributor

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-centos-e2e-integration-test-main

In response to this:

/override metal3-centos-e2e-integration-test-main
Centos is unstable, Ubuntu + unit passed.

/cc @mboukhalfa @lentzi90

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Rozzii
Copy link
Member

Rozzii commented May 21, 2024

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2024
lentzi90
lentzi90 reviewed May 21, 2024
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2024
@metal3-io-bot metal3-io-bot merged commit 95ac037 into metal3-io:main May 21, 2024
15 checks passed
@metal3-io-bot metal3-io-bot deleted the tuomo/refactor-tls-config branch May 21, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lentzi90 lentzi90 lentzi90 left review comments

@Rozzii Rozzii Awaiting requested review from Rozzii

@smoshiur1237 smoshiur1237 Awaiting requested review from smoshiur1237

@mboukhalfa mboukhalfa Awaiting requested review from mboukhalfa

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tuminoid @metal3-io-bot @Rozzii @lentzi90