-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱Add namespace directory in manifest collection #1800
Conversation
Signed-off-by: smoshiur1237 <[email protected]>
/test metal3-ubuntu-e2e-integration-test-main |
One test would be enough to check the added directory, so overriding the 2nd test. |
@smoshiur1237: Overrode contexts on behalf of smoshiur1237: metal3-centos-e2e-integration-test-main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @tuminoid @mboukhalfa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Manifest collection is done under different namespace directory: |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mboukhalfa, tuminoid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@smoshiur1237 Is it intentional that these new directories are empty? |
Okay, i have got my answer offline, probably in the future we should improve on this in terms of not creating all the "kind" directories for all the namespaces because many of them will be just empty dirs but this PR is a step in the right direction. |
There is a possibility to miss same kinds of manifest in different namespace. So this PR will add the namespace directory in manifest collection to gather all the manifests which will improve debugging capability.