Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱Add namespace directory in manifest collection #1800

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

smoshiur1237
Copy link
Member

There is a possibility to miss same kinds of manifest in different namespace. So this PR will add the namespace directory in manifest collection to gather all the manifests which will improve debugging capability.

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 19, 2024
@smoshiur1237
Copy link
Member Author

/test metal3-ubuntu-e2e-integration-test-main

@smoshiur1237
Copy link
Member Author

One test would be enough to check the added directory, so overriding the 2nd test.
/override metal3-centos-e2e-integration-test-main

@metal3-io-bot
Copy link
Contributor

@smoshiur1237: Overrode contexts on behalf of smoshiur1237: metal3-centos-e2e-integration-test-main

In response to this:

One test would be enough to check the added directory, so overriding the 2nd test.
/override metal3-centos-e2e-integration-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@smoshiur1237
Copy link
Member Author

/cc @tuminoid @mboukhalfa

Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2024
@smoshiur1237
Copy link
Member Author

smoshiur1237 commented Jun 19, 2024

Manifest collection is done under different namespace directory:
https://jenkins.nordix.org/view/Metal3/job/metal3-ubuntu-e2e-integration-test-main/310/

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboukhalfa, tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [mboukhalfa,tuminoid]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Rozzii
Copy link
Member

Rozzii commented Jun 19, 2024

@smoshiur1237 Is it intentional that these new directories are empty?
image
/hold
Just holding until I get answer

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 19, 2024
@Rozzii
Copy link
Member

Rozzii commented Jun 20, 2024

Okay, i have got my answer offline, probably in the future we should improve on this in terms of not creating all the "kind" directories for all the namespaces because many of them will be just empty dirs but this PR is a step in the right direction.
/hold cancel
/lgtm

@metal3-io-bot metal3-io-bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jun 20, 2024
@metal3-io-bot metal3-io-bot merged commit 0774d51 into metal3-io:main Jun 20, 2024
16 checks passed
@metal3-io-bot metal3-io-bot deleted the fix-manifest-moshiur branch June 20, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants