🌱 Fix issues in running local hack scripts #1810
Conversation
In CAPM3, there was only issues in codegen. Fix that, plus made it dynamically detect all the config and generated files, so they're included if they'd be generated elsewhere. It is in line with BMO generate.sh now. For others, simply adding one shellcheck ignore for a optional check many people have enabled about, tired of seeing my editor complain :) Signed-off-by: Tuomo Tanskanen <[email protected]>
metal3-io-bot
added
the
size/M
|
/override metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main |
|
@tuminoid: Overrode contexts on behalf of tuminoid: metal3-centos-e2e-integration-test-main, metal3-ubuntu-e2e-integration-test-main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cc @kashifest @Rozzii |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kashifest The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
In CAPM3, there was only issues in codegen. Fix that, plus made it dynamically detect all the config and generated files, so they're included if they'd be generated elsewhere. It is in line with BMO generate.sh now.
For others, simply adding one shellcheck ignore for a optional check many people have enabled about, tired of seeing my editor complain :)