-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 remove KUBECTL_SHA256 passthru #1822
🌱 remove KUBECTL_SHA256 passthru #1822
Conversation
We no longer need to pass-thru KUBECTL_SHA256 as we download it and verify it from the downloaded checksum. Signed-off-by: Tuomo Tanskanen <[email protected]>
OK, dev-env fix is in, let's see if we can merge this. /test metal3-ubuntu-e2e-integration-test-main metal3-centos-e2e-integration-test-main |
/cc @kashifest @Rozzii Good to merge. |
/retitle 🌱 remove KUBECTL_SHA256 passthru |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kashifest The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/gtm
/lgtm |
/cherry-pick release-1.7 |
@tuminoid: once the present PR merges, I will cherry-pick it on top of release-1.7 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@tuminoid: #1822 failed to apply on top of branch "release-1.7":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
We no longer need to pass-thru KUBECTL_SHA256 as we download it and verify it from the downloaded checksum.
This depends on metal3-io/metal3-dev-env#1437 merging first.
/hold