Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 remove KUBECTL_SHA256 passthru #1822

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

tuminoid
Copy link
Member

@tuminoid tuminoid commented Jul 1, 2024

We no longer need to pass-thru KUBECTL_SHA256 as we download it and verify it from the downloaded checksum.

This depends on metal3-io/metal3-dev-env#1437 merging first.
/hold

We no longer need to pass-thru KUBECTL_SHA256 as we download it and
verify it from the downloaded checksum.

Signed-off-by: Tuomo Tanskanen <[email protected]>
@metal3-io-bot metal3-io-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jul 1, 2024
@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 1, 2024
@tuminoid
Copy link
Member Author

tuminoid commented Jul 2, 2024

OK, dev-env fix is in, let's see if we can merge this.

/test metal3-ubuntu-e2e-integration-test-main metal3-centos-e2e-integration-test-main

@tuminoid
Copy link
Member Author

tuminoid commented Jul 2, 2024

/cc @kashifest @Rozzii
/retitle remove KUBECTL_SHA256 passthru
/unhold

Good to merge.

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 2, 2024
@metal3-io-bot metal3-io-bot changed the title WIP: 🌱 remove KUBECTL_SHA256 passthru remove KUBECTL_SHA256 passthru Jul 2, 2024
@metal3-io-bot metal3-io-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 2, 2024
@tuminoid
Copy link
Member Author

tuminoid commented Jul 2, 2024

/retitle 🌱 remove KUBECTL_SHA256 passthru

@metal3-io-bot metal3-io-bot changed the title remove KUBECTL_SHA256 passthru 🌱 remove KUBECTL_SHA256 passthru Jul 2, 2024
Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 2, 2024
Copy link
Member

@adilGhaffarDev adilGhaffarDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/gtm

@adilGhaffarDev
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 2, 2024
@tuminoid
Copy link
Member Author

tuminoid commented Jul 2, 2024

/cherry-pick release-1.7

@metal3-io-bot
Copy link
Contributor

@tuminoid: once the present PR merges, I will cherry-pick it on top of release-1.7 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot metal3-io-bot merged commit 02d128c into metal3-io:main Jul 2, 2024
25 of 26 checks passed
@metal3-io-bot metal3-io-bot deleted the tuomo/remove-kubectl-sha256 branch July 2, 2024 10:08
@metal3-io-bot
Copy link
Contributor

@tuminoid: #1822 failed to apply on top of branch "release-1.7":

Applying: remove KUBECTL_SHA256 passthru
Using index info to reconstruct a base tree...
M	scripts/ci-e2e.sh
M	scripts/environment.sh
Falling back to patching base and 3-way merge...
Auto-merging scripts/environment.sh
CONFLICT (content): Merge conflict in scripts/environment.sh
Auto-merging scripts/ci-e2e.sh
CONFLICT (content): Merge conflict in scripts/ci-e2e.sh
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 remove KUBECTL_SHA256 passthru
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants