🌱 Fixing bmo version for clusterctl tests #1833
Conversation
metal3-io-bot
added
the
size/XXL
|
/test ? |
|
@adilGhaffarDev: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test metal3-e2e-clusterctl-upgrade-test-release-1-7 |
adilGhaffarDev
force-pushed
the
fix-ironic-bmo-upgrade-1.7/adil
branch
2 times, most recently
from
0083818
to
2a96324
Compare
|
/test metal3-e2e-clusterctl-upgrade-test-release-1-7 |
Signed-off-by: adil ghaffar <[email protected]>
adilGhaffarDev
force-pushed
the
fix-ironic-bmo-upgrade-1.7/adil
branch
from
2a96324
to
2c49c13
Compare
|
/test metal3-e2e-clusterctl-upgrade-test-release-1-7 |
2 similar comments
|
/test metal3-e2e-clusterctl-upgrade-test-release-1-7 |
|
/test metal3-e2e-clusterctl-upgrade-test-release-1-7 |
|
/test metal3-centos-e2e-integration-test-release-1-7 |
|
@mboukhalfa please check |
| } | ||
|
|
||
| // KubectlDelete shells out to kubectl delete. | ||
| func KubectlDelete(ctx context.Context, kubeconfigPath string, resources []byte, args ...string) error { |
There was a problem hiding this comment.
Don't we have any capi framework function to delete manifests ?
There was a problem hiding this comment.
I was not able to find KubectlDelete in capi framework. They only have "apply" I think.
| fmt.Printf("stderr:\n%s\n", string(stderr)) | ||
| fmt.Printf("stdout:\n%s\n", string(stdout)) |
There was a problem hiding this comment.
we are we printing should not we send it to logs ?
There was a problem hiding this comment.
yes I agree, I will open PR on the main with the fix and backport it. There are some other improvements too that needs to be done in this code.
| default/wait-cluster: ["20m", "30s"] # The second time to check the availibility of the cluster should happen late, so kcp object has time to be created | ||
| default/wait-control-plane: ["30m", "10s"] | ||
| default/wait-worker-nodes: ["30m", "10s"] | ||
| default/wait-worker-nodes: ["60m", "10s"] |
There was a problem hiding this comment.
Was this needed can you include it to the PRs description why we do this
There was a problem hiding this comment.
the test was timing out here, thats why I changed it.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mboukhalfa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
|
@smoshiur1237 @Sunnatillo please check |
| mkdir -p "$CAPI_CONFIG_FOLDER" | ||
| echo "enableBMHNameBasedPreallocation: true" >"$CAPI_CONFIG_FOLDER/clusterctl.yaml" | ||
| mkdir -p "$CAPI_CONFIG_FOLDER" | ||
| echo "enableBMHNameBasedPreallocation: true" >"$CAPI_CONFIG_FOLDER/clusterctl.yaml" |
There was a problem hiding this comment.
This has been changed by the following PR: https://github.com/metal3-io/cluster-api-provider-metal3/pull/1751/files
There was a problem hiding this comment.
That is only on the main branch, we are not backporting it.
adilGhaffarDev
changed the title
What this PR does / why we need it:
Manual backport of this PR: #1596 on 1.7 branch.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Partial Fix of #1832