Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Uplift CAPI to v1.8.0-rc.0 #1859

Merged
merged 1 commit into from
Aug 1, 2024
Merged

🌱 Uplift CAPI to v1.8.0-rc.0 #1859

merged 1 commit into from
Aug 1, 2024

Conversation

adilGhaffarDev
Copy link
Member

@adilGhaffarDev adilGhaffarDev commented Jul 26, 2024 •
edited
Loading

What this PR does / why we need it:
Uplift CAPI to v1.8.0-rc.0
This PR also removes TLS tests and relies on cluster API ManagerOptions to set TLS flags. TLS tests are already there in CAPI so we don't need to test it again on our side.
ref PR: https://github.com/kubernetes-sigs/cluster-api/pull/10883/files

@adilGhaffarDev
Copy link
Member Author

/hold

@metal3-io-bot metal3-io-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 26, 2024
@adilGhaffarDev
Copy link
Member Author

/test metal3-e2e-clusterctl-upgrade-test-main

@adilGhaffarDev
Copy link
Member Author

/test metal3-e2e-clusterctl-upgrade-test-main

1 similar comment
@adilGhaffarDev
Copy link
Member Author

/test metal3-e2e-clusterctl-upgrade-test-main

@mboukhalfa
Copy link
Member

/test ?

@metal3-io-bot
Copy link
Contributor

@mboukhalfa: The following commands are available to trigger required jobs:

  • /test build
  • /test generate
  • /test gomod
  • /test manifestlint
  • /test markdownlint
  • /test metal3-centos-e2e-integration-test-main
  • /test metal3-ubuntu-e2e-integration-test-main
  • /test shellcheck
  • /test test
  • /test unit

The following commands are available to trigger optional jobs:

  • /test metal3-centos-e2e-basic-test-main
  • /test metal3-centos-e2e-feature-test-main-features
  • /test metal3-centos-e2e-feature-test-main-pivoting
  • /test metal3-centos-e2e-feature-test-main-remediation
  • /test metal3-e2e-1-26-1-27-upgrade-test-main
  • /test metal3-e2e-1-27-1-28-upgrade-test-main
  • /test metal3-e2e-1-28-1-29-upgrade-test-main
  • /test metal3-e2e-clusterctl-upgrade-test-main
  • /test metal3-ubuntu-e2e-basic-test-main
  • /test metal3-ubuntu-e2e-feature-test-main-features
  • /test metal3-ubuntu-e2e-feature-test-main-pivoting
  • /test metal3-ubuntu-e2e-feature-test-main-remediation

Use /test all to run the following jobs that were automatically triggered:

  • build
  • generate
  • gomod
  • manifestlint
  • unit

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mboukhalfa
Copy link
Member

/test metal3-e2e-clusterctl-upgrade-test-main

@smoshiur1237
Copy link
Member

/test metal3-centos-e2e-integration-test-main

@NymanRobin
Copy link
Member

/retest

@NymanRobin
Copy link
Member

/test metal3-centos-e2e-integration-test-main

@adilGhaffarDev
Copy link
Member Author

/test metal3-e2e-clusterctl-upgrade-test-main

1 similar comment
@adilGhaffarDev
Copy link
Member Author

/test metal3-e2e-clusterctl-upgrade-test-main

@adilGhaffarDev
Copy link
Member Author

/test all

@adilGhaffarDev
Copy link
Member Author

passed for once: https://jenkins.nordix.org/view/Metal3/job/metal3-e2e-clusterctl-upgrade-test-main/75/
running it again just to confirm:
/test metal3-e2e-clusterctl-upgrade-test-main

@adilGhaffarDev
Copy link
Member Author

passed 2nd time too: https://jenkins.nordix.org/view/Metal3/job/metal3-e2e-clusterctl-upgrade-test-main/76/
running one last time
/test metal3-e2e-clusterctl-upgrade-test-main

@adilGhaffarDev
Copy link
Member Author

/test metal3-e2e-clusterctl-upgrade-test-main

@adilGhaffarDev
Uplift CAPI to v1.8.0-rc.0
33240cf 
Signed-off-by: Muhammad Adil Ghaffar <[email protected]>
@adilGhaffarDev adilGhaffarDev changed the title 🌱 Test PR 🌱 Uplift CAPI to v1.8.0-rc.0 Jul 31, 2024
@adilGhaffarDev
Copy link
Member Author

/unhold

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 31, 2024
@adilGhaffarDev
Copy link
Member Author

this PR superseding this one: #1845
lets close: #1845 , when this is merged.

@adilGhaffarDev
Copy link
Member Author

cc @smoshiur1237 @Sunnatillo

@adilGhaffarDev
Copy link
Member Author

/test metal3-ubuntu-e2e-integration-test-main
/test metal3-centos-e2e-integration-test-main

@Sunnatillo Sunnatillo mentioned this pull request Jul 31, 2024
Closed
@adilGhaffarDev
Copy link
Member Author

cc @smoshiur1237 @Sunnatillo

Sunnatillo
Sunnatillo reviewed Aug 1, 2024
View reviewed changes
Copy link
Member

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Sunnatillo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2024
@adilGhaffarDev
Copy link
Member Author

/test ?

@metal3-io-bot
Copy link
Contributor

@adilGhaffarDev: The following commands are available to trigger required jobs:

  • /test build
  • /test generate
  • /test gomod
  • /test manifestlint
  • /test markdownlint
  • /test metal3-centos-e2e-integration-test-main
  • /test metal3-ubuntu-e2e-integration-test-main
  • /test shellcheck
  • /test test
  • /test unit

The following commands are available to trigger optional jobs:

  • /test metal3-centos-e2e-basic-test-main
  • /test metal3-centos-e2e-feature-test-main-features
  • /test metal3-centos-e2e-feature-test-main-pivoting
  • /test metal3-centos-e2e-feature-test-main-remediation
  • /test metal3-e2e-1-26-1-27-upgrade-test-main
  • /test metal3-e2e-1-27-1-28-upgrade-test-main
  • /test metal3-e2e-1-28-1-29-upgrade-test-main
  • /test metal3-e2e-clusterctl-upgrade-test-main
  • /test metal3-ubuntu-e2e-basic-test-main
  • /test metal3-ubuntu-e2e-feature-test-main-features
  • /test metal3-ubuntu-e2e-feature-test-main-pivoting
  • /test metal3-ubuntu-e2e-feature-test-main-remediation

Use /test all to run the following jobs that were automatically triggered:

  • build
  • generate
  • gomod
  • manifestlint
  • unit

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@adilGhaffarDev
Copy link
Member Author

/test metal3-e2e-clusterctl-upgrade-test-main

@adilGhaffarDev
Copy link
Member Author

/test metal3-ubuntu-e2e-basic-test-main
/test metal3-ubuntu-e2e-feature-test-main-pivoting

@smoshiur1237
Copy link
Member

/test metal3-ubuntu-e2e-feature-test-main-pivoting

@smoshiur1237
Copy link
Member

Clusterctl upgrade, basic e2e and feature test pivoting passed already.
/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 1, 2024
@metal3-io-bot metal3-io-bot merged commit d332cfa into metal3-io:main Aug 1, 2024
28 of 29 checks passed
@metal3-io-bot metal3-io-bot deleted the test-pr-uplift-1.8beta/adil branch August 1, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sunnatillo Sunnatillo Sunnatillo left review comments

@mboukhalfa mboukhalfa Awaiting requested review from mboukhalfa

@zhouhao3 zhouhao3 Awaiting requested review from zhouhao3

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@adilGhaffarDev @mboukhalfa @metal3-io-bot @smoshiur1237 @NymanRobin @Sunnatillo