Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Bump k8s to v1.31.0 and drop caBundle from CRDs to support Kubernetes 1.31 #1866

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

adilGhaffarDev
Copy link
Member

@adilGhaffarDev adilGhaffarDev commented Aug 1, 2024

What this PR does / why we need it:
Bump k8s to v1.31.0 and Drop caBundle from CRDs to support Kubernetes 1.31.
ref: kubernetes-sigs/cluster-api#10972

In addition this PR is also the fix in ip_reuse test, in the test when doing k8s upgrade from 1.30.0 to 1.31.0 we were only changing k8s version in MachineDeployment, which is not enough we have to update Metal3MachineTemplate too with the new image, and sha. It is fixed now in this PR.

@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 1, 2024
scripts/environment.sh Outdated Show resolved Hide resolved
Signed-off-by: Muhammad Adil Ghaffar <[email protected]>
@adilGhaffarDev
Copy link
Member Author

/hold
wait until node images are available in artifactory

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 1, 2024
@adilGhaffarDev
Copy link
Member Author

/test ?

@metal3-io-bot
Copy link
Contributor

@adilGhaffarDev: The following commands are available to trigger required jobs:

  • /test build
  • /test generate
  • /test gomod
  • /test manifestlint
  • /test markdownlint
  • /test metal3-centos-e2e-integration-test-main
  • /test metal3-ubuntu-e2e-integration-test-main
  • /test shellcheck
  • /test test
  • /test unit

The following commands are available to trigger optional jobs:

  • /test metal3-centos-e2e-basic-test-main
  • /test metal3-centos-e2e-feature-test-main-features
  • /test metal3-centos-e2e-feature-test-main-pivoting
  • /test metal3-centos-e2e-feature-test-main-remediation
  • /test metal3-e2e-1-26-1-27-upgrade-test-main
  • /test metal3-e2e-1-27-1-28-upgrade-test-main
  • /test metal3-e2e-1-28-1-29-upgrade-test-main
  • /test metal3-e2e-clusterctl-upgrade-test-main
  • /test metal3-ubuntu-e2e-basic-test-main
  • /test metal3-ubuntu-e2e-feature-test-main-features
  • /test metal3-ubuntu-e2e-feature-test-main-pivoting
  • /test metal3-ubuntu-e2e-feature-test-main-remediation

Use /test all to run the following jobs that were automatically triggered:

  • build
  • generate
  • gomod
  • manifestlint
  • markdownlint
  • shellcheck
  • test
  • unit

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@adilGhaffarDev
Copy link
Member Author

/test metal3-ubuntu-e2e-feature-test-main-features

@adilGhaffarDev
Copy link
Member Author

/test metal3-ubuntu-e2e-integration-test-main

@adilGhaffarDev
Copy link
Member Author

/test metal3-ubuntu-e2e-feature-test-main-features

@Sunnatillo
Copy link
Member

/test metal3-ubuntu-e2e-integration-test-main

@adilGhaffarDev
Copy link
Member Author

/test metal3-ubuntu-e2e-feature-test-main-features

@adilGhaffarDev
Copy link
Member Author

/test metal3-ubuntu-e2e-basic-test-main

2 similar comments
@adilGhaffarDev
Copy link
Member Author

/test metal3-ubuntu-e2e-basic-test-main

@adilGhaffarDev
Copy link
Member Author

/test metal3-ubuntu-e2e-basic-test-main

@adilGhaffarDev
Copy link
Member Author

/test metal3-ubuntu-e2e-feature-test-main-features
/test metal3-ubuntu-e2e-integration-test-main

@adilGhaffarDev
Copy link
Member Author

/test metal3-centos-e2e-feature-test-main-features

@Sunnatillo
Copy link
Member

/test metal3-centos-e2e-feature-test-main-features
/test metal3-ubuntu-e2e-feature-test-main-features

@adilGhaffarDev
Copy link
Member Author

/test metal3-ubuntu-e2e-feature-test-main-pivoting
/test metal3-ubuntu-e2e-feature-test-main-remediation

@metal3-io-bot metal3-io-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 12, 2024
@adilGhaffarDev
Copy link
Member Author

/test metal3-centos-e2e-feature-test-main-features
/test metal3-ubuntu-e2e-feature-test-main-features

@adilGhaffarDev
Copy link
Member Author

/test metal3-ubuntu-e2e-feature-test-main-features

@adilGhaffarDev
Copy link
Member Author

/test metal3-ubuntu-e2e-feature-test-main-features

@adilGhaffarDev
Copy link
Member Author

adilGhaffarDev commented Aug 12, 2024

tests passed after the fix in ip_reuse test, in the test when doing k8s upgrade from 1.30 to 1.31-rc.0 or 1.31.0 we were only changing k8s version in MachineDeployment, which is not enough we have to update Metal3MachineTemplate too with the new image, and sha. It is fixed now. ref to passed test: https://jenkins.nordix.org/view/Metal3/job/metal3-ubuntu-e2e-feature-test-main-features/8/consoleFull

Now running remaining tests.

/test metal3-ubuntu-e2e-feature-test-main-pivoting
/test metal3-ubuntu-e2e-feature-test-main-remediation
/test metal3-centos-e2e-feature-test-main-features

these should be enough to say that k8s 1.31-rc.0 uplift is working. I will run e2e-integeration tests once these are passed.

@adilGhaffarDev
Copy link
Member Author

/test metal3-centos-e2e-integration-test-main
/test metal3-ubuntu-e2e-integration-test-main

@Sunnatillo
Copy link
Member

/test metal3-e2e-1-28-1-29-upgrade-test-main

@adilGhaffarDev
Copy link
Member Author

/unhold

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 14, 2024
@Sunnatillo
Copy link
Member

/retitle 🌱 Bump k8s to v1.31.0 and drop caBundle from CRDs to support Kubernetes 1.31

@metal3-io-bot metal3-io-bot changed the title 🌱 Bump k8s to v1.31.0-rc.0 and drop caBundle from CRDs to support Kubernetes 1.31 🌱 Bump k8s to v1.31.0 and drop caBundle from CRDs to support Kubernetes 1.31 Aug 14, 2024
@adilGhaffarDev
Copy link
Member Author

/test metal3-centos-e2e-feature-test-main-features
/test metal3-centos-e2e-integration-test-main
/test metal3-ubuntu-e2e-integration-test-main

@metal3-io-bot
Copy link
Contributor

metal3-io-bot commented Aug 15, 2024

@adilGhaffarDev: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
metal3-ubuntu-e2e-feature-test-main-pivoting 8d08228 link false /test metal3-ubuntu-e2e-feature-test-main-pivoting

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@adilGhaffarDev
Copy link
Member Author

seems like a flake, bmhs were provisioned evetually
/test metal3-centos-e2e-feature-test-main-features

@adilGhaffarDev
Copy link
Member Author

tests passed, @Sunnatillo @kashifest @smoshiur1237 please check.

@kashifest
Copy link
Member

tests passed, @Sunnatillo @kashifest @smoshiur1237 please check.

what was the issue

Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smoshiur1237

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2024
@adilGhaffarDev
Copy link
Member Author

what was the issue

it was in ip_reuse test, it is explained here: #1866 (comment)

@kashifest
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 16, 2024
@metal3-io-bot metal3-io-bot merged commit b78205c into metal3-io:main Aug 16, 2024
32 of 33 checks passed
@metal3-io-bot metal3-io-bot deleted the uplift-k8s-v1.31.0-rc.0/adil branch August 16, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants