Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Uplift CAPI to v1.8.0-rc.1 #1874

Merged
merged 1 commit into from
Aug 8, 2024
Merged

🌱 Uplift CAPI to v1.8.0-rc.1 #1874

merged 1 commit into from
Aug 8, 2024

Conversation

Sunnatillo
Copy link
Member

Bumps CAPI to v1.8.0-rc.1

@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 7, 2024
@Sunnatillo
Copy link
Member Author

/test metal3-centos-e2e-integration-test-main
/test metal3-ubuntu-e2e-integration-test-main

tuminoid
tuminoid reviewed Aug 7, 2024
View reviewed changes
docs/e2e-test.md Outdated Show resolved Hide resolved
kashifest
kashifest reviewed Aug 7, 2024
View reviewed changes
Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Aug 7, 2024
@Sunnatillo Sunnatillo force-pushed the uplift-capi-v1.8.0-rc.1/sunnat branch from fbfa101 to 9f9d2f3 Compare August 7, 2024 07:14
@Sunnatillo
Copy link
Member Author

/test metal3-centos-e2e-integration-test-main
/test metal3-ubuntu-e2e-integration-test-main

tuminoid
tuminoid reviewed Aug 7, 2024
View reviewed changes
docs/e2e-test.md Outdated Show resolved Hide resolved
@tuminoid
Copy link
Member

tuminoid commented Aug 7, 2024

/retest

@Sunnatillo
CAPI uplift to v1.8.0-rc.1
6593054 
Signed-off-by: Sunnatillo <[email protected]>
@Sunnatillo Sunnatillo force-pushed the uplift-capi-v1.8.0-rc.1/sunnat branch from 9f9d2f3 to 6593054 Compare August 7, 2024 17:04
@Sunnatillo
Copy link
Member Author

/override metal3-centos-e2e-integration-test-main
/override metal3-ubuntu-e2e-integration-test-main

The tests passed on previously. I did one space change.

@metal3-io-bot
Copy link
Contributor

@Sunnatillo: Overrode contexts on behalf of Sunnatillo: metal3-centos-e2e-integration-test-main, metal3-ubuntu-e2e-integration-test-main

In response to this:

/override metal3-centos-e2e-integration-test-main
/override metal3-ubuntu-e2e-integration-test-main

The tests passed on previously. I did one space change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Sunnatillo
Copy link
Member Author

/unhold

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 7, 2024
tuminoid
tuminoid reviewed Aug 8, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 8, 2024
@metal3-io-bot metal3-io-bot merged commit 5a4c334 into metal3-io:main Aug 8, 2024
18 checks passed
@metal3-io-bot metal3-io-bot deleted the uplift-capi-v1.8.0-rc.1/sunnat branch August 8, 2024 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kashifest kashifest kashifest left review comments

@tuminoid tuminoid tuminoid left review comments

@mboukhalfa mboukhalfa Awaiting requested review from mboukhalfa

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Sunnatillo @metal3-io-bot @tuminoid @kashifest