Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Add CAPI v1.8 contract #1888

Merged
merged 1 commit into from
Aug 26, 2024
Merged

🌱 Add CAPI v1.8 contract #1888

merged 1 commit into from
Aug 26, 2024

Conversation

kashifest
Copy link
Member

This PR add CAPI v1.8 contracts

@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 13, 2024
@adilGhaffarDev adilGhaffarDev mentioned this pull request Aug 13, 2024
Closed
50 tasks
@adilGhaffarDev
Copy link
Member

Should we also update the e2e-conf file in this PR or open a separate one for that?

@kashifest
Copy link
Member Author

I was thinking the same, didnt touch it thinking if that would affect the tests before the release, would it ?

@adilGhaffarDev
Copy link
Member

I was thinking the same, didnt touch it thinking if that would affect the tests before the release, would it ?

It should not affect anything if we add a new version but those changes are mostly related to clusterctl tests, I will open a separate PR that updates the tests and also update the e2e-config file.

smoshiur1237
smoshiur1237 reviewed Aug 13, 2024
View reviewed changes
Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 13, 2024
@adilGhaffarDev
Copy link
Member

/hold
let's merge this one once we have the 1.8 branch. for ref : https://github.com/kubernetes-sigs/cluster-api/tree/main/test/e2e/data/shared CAPI still using 1.7 in contracts and updating this is part of the next release cycle. This is needed on the main after v1.8 release, not on the v1.8 branch.

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 13, 2024
@adilGhaffarDev
Copy link
Member

Ok, I checked again test/e2e/data/infrastructure-metal3/v1.8/metadata.yaml and test/e2e/data/shared/v1.8/metadata.yaml are only needed in the main branch so let's add them once we have release-1.8 branch. Other changes we can already merge.

@metal3-io-bot metal3-io-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 20, 2024
@kashifest
Copy link
Member Author

Ok, I checked again test/e2e/data/infrastructure-metal3/v1.8/metadata.yaml and test/e2e/data/shared/v1.8/metadata.yaml are only needed in the main branch so let's add them once we have release-1.8 branch. Other changes we can already merge.

Done.
/hold cancel

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 20, 2024
@kashifest
Copy link
Member Author

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

adilGhaffarDev
adilGhaffarDev previously approved these changes Aug 20, 2024
View reviewed changes
Copy link
Member

@adilGhaffarDev adilGhaffarDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 20, 2024
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adilGhaffarDev, smoshiur1237

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [adilGhaffarDev,smoshiur1237]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kashifest
Add CAPI v1.8 contract
0e8ad92 
Signed-off-by: Kashif Khan <[email protected]>
@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 20, 2024
@kashifest
Copy link
Member Author

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

@tuminoid
Copy link
Member

/retest

@tuminoid
Copy link
Member

/retest
Artfifactory issues.

@kashifest
Copy link
Member Author

/retest

@kashifest
Copy link
Member Author

/retest

@adilGhaffarDev
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2024
@kashifest
Copy link
Member Author

/retest

@metal3-io-bot metal3-io-bot merged commit 4eb2a2a into metal3-io:main Aug 26, 2024
16 checks passed
@metal3-io-bot metal3-io-bot deleted the add/capi-v1.8-contract branch August 26, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoshiur1237 smoshiur1237 smoshiur1237 left review comments

@adilGhaffarDev adilGhaffarDev adilGhaffarDev left review comments

@dtantsur dtantsur Awaiting requested review from dtantsur

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kashifest @adilGhaffarDev @metal3-io-bot @tuminoid @smoshiur1237