Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Bump CAPI to v1.8.1 #1889

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

Sunnatillo
Copy link
Member

@Sunnatillo Sunnatillo commented Aug 14, 2024

Uplifts CAPI to v1.8.1

Part of: #1887

@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 14, 2024
Signed-off-by: Sunnatillo <[email protected]>
@Sunnatillo
Copy link
Member Author

/test metal3-centos-e2e-integration-test-main
/test metal3-ubuntu-e2e-integration-test-main

@Sunnatillo
Copy link
Member Author

/cc @tuminoid @adilGhaffarDev @mquhuy

Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 14, 2024
@adilGhaffarDev
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 14, 2024
@adilGhaffarDev
Copy link
Member

can you add in pr description part of #1887

Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

--control-plane kubeadm:v1.8.0 -v5
clusterctl init --core cluster-api:v1.8.1 \
--bootstrap kubeadm:v1.8.1 \
--control-plane kubeadm:v1.8.1 -v5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we decided not to touch these README for patch releases?

Copy link
Member Author

@Sunnatillo Sunnatillo Aug 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not remember. But why?
IMHO if we do not change every time, we most likely forget to update it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It prevents dependabot from doing these bumps as it cannot handle README.md

README doesn't need to update all the time, so bump once when bumpign minor and then leave alone and let bot do it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noted. Next time I will not update it.

@kashifest
Copy link
Member

/lgtm
/hold
Small nit inline

@metal3-io-bot metal3-io-bot merged commit b5fdefd into metal3-io:main Aug 14, 2024
24 checks passed
@metal3-io-bot metal3-io-bot deleted the uplift-capi-v1.8.1/sunnat branch August 14, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants