Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add live-iso support to CAPI Metal3 provider #189

Merged
merged 13 commits into from
May 26, 2021
Merged

✨ Add live-iso support to CAPI Metal3 provider #189

merged 13 commits into from
May 26, 2021

Conversation

levsha
Copy link
Contributor

@levsha levsha commented Apr 7, 2021

metal3-io/baremetal-operator#759 adds "live-iso" image format support to BMO.
However CAPI needs to support it too for full functionality is image-related fields usually come from Metal3MachineTemplate trough Metal3Machine to BareMetalHost.

Tested: on a local kind cluster.

@metal3-io-bot metal3-io-bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 7, 2021
@metal3-io-bot
Copy link
Contributor

Hi @levsha. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fmuyassarov
Copy link
Member

/ok-to-test

@metal3-io-bot metal3-io-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 7, 2021
@fmuyassarov
Copy link
Member

/retest

@levsha
Copy link
Contributor Author

levsha commented Apr 7, 2021

/test generate

@fmuyassarov
Copy link
Member

@levsha you are probably missing make generate changes. Can you please run make generate and add the changes?

@levsha
Copy link
Contributor Author

levsha commented Apr 7, 2021

/test golint

@levsha
Copy link
Contributor Author

levsha commented Apr 7, 2021

@levsha you are probably missing make generate changes. Can you please run make generate and add the changes?

That helped. Thanks!

@levsha
Copy link
Contributor Author

levsha commented Apr 21, 2021

/assign @hardys

@maelk
Copy link
Member

maelk commented Apr 29, 2021

lgtm

@levsha
Copy link
Contributor Author

levsha commented May 3, 2021

/retest

@kashifest
Copy link
Member

Do we need to add this to CAPM3 v1a3 types as well? Can't we live with v1a4 only now since v1a3 is close to its lifetime ?

@levsha
Copy link
Contributor Author

levsha commented May 7, 2021

Do we need to add this to CAPM3 v1a3 types as well? Can't we live with v1a4 only now since v1a3 is close to its lifetime ?

I guess it should be ok to only have it in v1a4 only. Especially that this is new functionality, so we don't have to backport it.

@metal3-io-bot metal3-io-bot added the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label May 7, 2021
@metal3-io-bot metal3-io-bot removed the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label May 23, 2021
@metal3-io-bot metal3-io-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 23, 2021
@levsha
Copy link
Contributor Author

levsha commented May 23, 2021

Do we need to add this to CAPM3 v1a3 types as well? Can't we live with v1a4 only now since v1a3 is close to its lifetime ?

I've rolled back changes for v1alpha3

@fmuyassarov
Copy link
Member

/test-integration

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest, levsha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2021
Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label May 26, 2021
@metal3-io-bot metal3-io-bot merged commit 7afc58c into metal3-io:master May 26, 2021
@levsha levsha deleted the live-iso branch May 26, 2021 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants