-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add live-iso support to CAPI Metal3 provider #189
Conversation
Hi @levsha. Thanks for your PR. I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/retest |
/test generate |
@levsha you are probably missing |
/test golint |
That helped. Thanks! |
/assign @hardys |
lgtm |
/retest |
Do we need to add this to CAPM3 v1a3 types as well? Can't we live with v1a4 only now since v1a3 is close to its lifetime ? |
I guess it should be ok to only have it in v1a4 only. Especially that this is new functionality, so we don't have to backport it. |
…al3 into live-iso
I've rolled back changes for v1alpha3 |
/test-integration |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kashifest, levsha The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
metal3-io/baremetal-operator#759 adds "live-iso" image format support to BMO.
However CAPI needs to support it too for full functionality is image-related fields usually come from Metal3MachineTemplate trough Metal3Machine to BareMetalHost.
Tested: on a local kind cluster.